commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bindul <...@git.apache.org>
Subject [GitHub] commons-compress pull request #23: Add Brotli Support
Date Tue, 02 May 2017 06:47:25 GMT
Github user bindul commented on a diff in the pull request:

    https://github.com/apache/commons-compress/pull/23#discussion_r114257132
  
    --- Diff: pom.xml ---
    @@ -68,6 +68,12 @@ jar, tar, zip, dump, 7z, arj.
           <scope>test</scope>
         </dependency>
         <dependency>
    +      <groupId>org.brotli</groupId>
    +      <artifactId>dec</artifactId>
    +      <version>0.1.1</version>
    +      <scope>compile</scope>
    --- End diff --
    
    Shouldn't this be an optional dependency, just like the xz one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message