commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@bpm-inspire.com>
Subject Re: [lang] new concurrency annotations
Date Tue, 18 Apr 2017 07:14:07 GMT
Benedikt Ritter wrote:

> Hi,
> 
>> Am 18.04.2017 um 08:36 schrieb Gary Gregory <garydgregory@gmail.com>:
>> 
>> Hi All:
>> 
>> We have two styles for the new concurrency annotations in master:
>> 
>> (1) JCIP
>> (2) Apache HttpComponents Core
>> 
>> I would like to delete (1) in favor of (2). I started this discussion
>> inappropriately on a VOTE thread, sorry for the redo.
> 
> Yes, this makes sense in the light of the reason you gave on the other
> thread.
> 
>> 
>> Then we can proceed with another release candidate.
>> 
>> Also at issue is where the new annotations belong
>> 
>> (1) org.apache.commons.lang3.concurrent.annotation (current)
>> (2) org.apache.commons.lang3.annotation (my preferred location)
> 
> What about (3) org.apache.commons.lang3.concurrent ?
> 
> I don’t think it’s good style to package things by their technical nature.
> Why do annotations deserve their own package? Why don’t we have
> o.a.c.l.enum/abstractclass/expection then? From my PoV its easier to
> understand if things are packaged by their domain. For this reason I’d
> argue @Contract belongs to o.a.c.l.concurrent (without sub package)

+1

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message