commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [ALL] explicit Maven groupId in component POMs
Date Fri, 21 Apr 2017 16:39:05 GMT
On 21 April 2017 at 16:54, Benedikt Ritter <britter@apache.org> wrote:
>
>> Am 21.04.2017 um 15:12 schrieb sebb <sebbaz@gmail.com>:
>>
>> Commons components use two different styles of groupId:
>>
>> commons-<component> - used by some original components (e.g. IO, NET)
>> org.apache.commons - newer style, used by most components
>>
>> Since Commons Parent uses the latter, and the groupId is inherited, in
>> theory a component using the new groupId does not need to specify it.
>>
>> However, I think that is unwise, as it's not clear whether the
>> omission is deliberate or accidental.
>> Also the parent could potentially be changed to one with a different groupId.
>>
>> Far better to specify the groupId explicitly rather than relying on an
>> inherited default.
>>
>> Agreed?
>
> -1: it’s redundant and unnecessary.

Strictly speaking, yes.

But the problem is that it would be very easy to change the parent gid
and assume that everything is still OK.

Especially with Commons which has a mixture of groupIds, I think it's
important to explicitly state the intended groupId for each component.

>>
>> S.
>> P.S. Note that changing the groupId can only be done if the package
>> name is also changed, see
>> https://wiki.apache.org/commons/MavenAndClasspath
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message