commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tballison <...@git.apache.org>
Subject [GitHub] commons-compress pull request #20: COMPRESS-382
Date Tue, 25 Apr 2017 12:05:34 GMT
Github user tballison commented on a diff in the pull request:

    https://github.com/apache/commons-compress/pull/20#discussion_r113176495
  
    --- Diff: src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java
---
    @@ -56,7 +56,7 @@ public LZMACompressorInputStream(final InputStream inputStream)
                 in = new LZMAInputStream(inputStream, MemoryLimit.getMemoryLimitInKb());
             } catch (org.tukaani.xz.MemoryLimitException e) {
                 //convert to commons-compress exception
    -            throw new MemoryLimitException("exceeded calculated memory limit", e);
    +            throw new MemoryLimitException(e.getMemoryNeeded(), e.getMemoryLimit());
    --- End diff --
    
    Y.  Good point.  I'll update our MemoryLimitException initializers to both a 2-parameter
(needed, limit) and 3-parameter (needed, limit, e)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message