commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebbASF <...@git.apache.org>
Subject [GitHub] commons-compress pull request #21: COMPRESS-388: Fix concurrent reads perfor...
Date Sun, 23 Apr 2017 16:40:26 GMT
Github user sebbASF commented on a diff in the pull request:

    https://github.com/apache/commons-compress/pull/21#discussion_r112838915
  
    --- Diff: src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java ---
    @@ -1111,14 +1122,11 @@ public int read() throws IOException {
                     }
                     return -1;
                 }
    -            synchronized (archive) {
    -                archive.position(loc++);
    -                int read = read(1);
    -                if (read < 0) {
    -                    return read;
    -                }
    -                return buffer.get() & 0xff;
    +            int read = read(loc++, 1);
    +            if (read < 0) {
    --- End diff --
    
    OK. This needs to be clarified in the Javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message