Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Subject: Re: [CONFIGURATION] Changing method parameter to base class type
To: Commons Developers List <dev@commons.apache.org>
References: <6e48c5d4-4d76-78e7-035c-d60c328f523c@oliver-heger.de>
 <0080a0e5-1013-08a2-8057-804026ea86b0@gmx.net>
From: Oliver Heger <oliver.heger@oliver-heger.de>
Message-ID: <01522205-6098-e820-3d33-1e8ad92650f8@oliver-heger.de>
Date: Sat, 4 Mar 2017 15:54:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <0080a0e5-1013-08a2-8057-804026ea86b0@gmx.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 04 Mar 2017 14:54:12 -0000

Hi Pascal,

Am 03.03.2017 um 23:33 schrieb Pascal Schumacher:
> Hi Oliver,
> 
> guess clirr is complaining because changing the parameter type of
> methods is not binary compatible:
> 
> http://stackoverflow.com/questions/1365409/refactored-methods-and-binary-compatibility-in-java
> 
> 
> http://wiki.eclipse.org/Evolving_Java-based_APIs_2

yep, it was late yesterday. I came to the same conclusion after
switching off my computer. The change is source compatible, but not
binary compatible.

I guess our best bet is to add new overloaded methods using the new
parameter type and let the old ones delegate.

Thanks
Oliver

> 
> -Pascal
> 
> Am 03.03.2017 um 22:32 schrieb Oliver Heger:
>> Hi,
>>
>> in CONFIGURATION-653 [1] it is proposed to change the type of some
>> method parameters of utility methods from Configuration to the base type
>> ImmutableConfiguration. This makes those methods broader in scope.
>>
>> I would expect that this is a change which should not affect client
>> code. Nevertheless, clirr reports errors in these cases. I could imagine
>> that there was a risk to break clients that override one of these
>> methods. But they are static, so this should not be an issue.
>>
>> Do I miss something?
>> Oliver
>>
>> [1] https://issues.apache.org/jira/browse/CONFIGURATION-653
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org