commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: [POOL] Use of Exception for caller class info
Date Fri, 03 Mar 2017 18:10:49 GMT
Created <https://issues.apache.org/jira/browse/POOL-320>. I should be able
to implement this over the weekend hopefully.

On 3 March 2017 at 12:05, Matt Sicker <boards@gmail.com> wrote:

> Ok, glad to hear it's nothing specific. I'll make a ticket to track this.
>
> On 3 March 2017 at 11:58, Mark Thomas <markt@apache.org> wrote:
>
>> On 03/03/2017 16:13, Matt Sicker wrote:
>> > I started using commons-pool 2 yesterday to implement connection pooling
>> > for Elasticsearch (mainly for health checking, though who knows where
>> this
>> > internal project ends up going) and I noticed that Exception is used to
>> > track users of objects from the pool. In Log4j, we use a myriad of
>> > strategies to obtain caller class info that are much faster than
>> generating
>> > a stack trace such as the internal sun Reflection class, a
>> SecurityManager,
>> > and we're also looking at the Java 9 StackWalker class which provides a
>> > standard way of doing it. Is there any particular reason why
>> > DefaultPooledObject uses Exception instead of faster strategies?
>>
>> The code dates back a good number of years (probably more than a decade)
>> and no-one - to date - has felt the urge to improve it.
>>
>> As always, patches welcome.
>>
>> Mark
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> Matt Sicker <boards@gmail.com>
>



-- 
Matt Sicker <boards@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message