commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stain <...@git.apache.org>
Subject [GitHub] commons-rdf pull request #30: COMMONSRDF-51 language tags compared lower cas...
Date Thu, 12 Jan 2017 14:53:20 GMT
GitHub user stain opened a pull request:

    https://github.com/apache/commons-rdf/pull/30

    COMMONSRDF-51 language tags compared lower case

    This fixes [COMMONSRDF-51](https://issues.apache.org/jira/browse/COMMONSRDF-51) - at least
from `Literal.equals()` and `Literal.hashCode()`
    
    Further test might be needed to verify consistent behaviour in `Graph` and `Dataset` if
underlying framework does not correctly do langtag comparison in lower case (e.g. Turkish
locale problem).
    
    Please comment on the fixes and the suggested updated javadoc:
    
    * [Literal.equals(Object)](http://stain.github.io/commons-rdf/COMMONSRDF-51/org/apache/commons/rdf/api/Literal.html#equals-java.lang.Object-)
    * [Literal.hashCode()](http://stain.github.io/commons-rdf/COMMONSRDF-51/org/apache/commons/rdf/api/Literal.html#hashCode--)
    * [Literal.getLanguageTag()](http://stain.github.io/commons-rdf/COMMONSRDF-51/org/apache/commons/rdf/api/Literal.html#getLanguageTag--)
    
    For code improvements of this PR, feel free to push to the `COMMONSRDF-51-langtag-lcase`
branch at https://git-wip-us.apache.org/repos/asf/commons-rdf.git or use the "Start review"
mechanism in GitHub.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/commons-rdf COMMONSRDF-51-langtag-lcase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-rdf/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 3064d219606cbe42c0150d81dbf6cdbc74bf7491
Author: Stian Soiland-Reyes <stain@apache.org>
Date:   2017-01-12T14:51:26Z

    COMMONSRDF-51: compare language tags in lower case

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message