commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raymond DeCampo <...@decampo.org>
Subject Re: [5/5] commons-numbers git commit: Add maven module for fractions package from commons-math Resolves pull request #4
Date Sat, 28 Jan 2017 14:00:52 GMT
Thanks for the feedback Gilles.

I generally prefer to work in smaller increments so that suits me fine.

Re working on an outdated branch, I'm not sure I completely understand what
you want plus I am not a git expert by any stretch.  Are you suggesting I
back out the changes on the multimodule branch using rebase?  Then
following the guidelines from doc/development create a feature branch and
then chunk the changes up into digestible commits on that branch?

I realized my mistake on not referring to the JIRA issue on the commit
right away (it's always something).



On Sat, Jan 28, 2017 at 8:36 AM, Gilles <gilles@harfang.homelinux.org>
wrote:

> Hi Ray.
>
> On Sat, 28 Jan 2017 12:44:27 -0000, raydecampo@apache.org wrote:
>
>> Add maven module for fractions package from commons-math
>> Resolves pull request #4
>>
>
> Whenever possible, we aim at small commits (unless they are all of
> the same kind, and it is obvious what is being done repeatedly).
>
> In particular, independent codes should be added incrementally, to
> allow for easier review.
> For example, modifications to "pom.xml", addition of "ArithmeticUtils",
> "Fraction" and "BigFraction", etc.
>
> Please note that you worked on an outdated branch.
> [Please read the guidelines in "doc/development".]
> Can you fix that (using "rebase" I guess) before we discuss the
> contents of the commit?
>
> Also to allow easy review: the commit message should refer to the
> JIRA issue identifier).
>
>
> Thanks,
> Gilles
>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
>> Commit:
>>
>> http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/763ec4fe
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/
>> 763ec4fe
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/
>> 763ec4fe
>>
>> Branch: refs/heads/multimodule
>> Commit: 763ec4fea595ea53792bf2a7d3dd08dedc567909
>> Parents: 69d3b62 aaef6f7
>> Author: Ray DeCampo <ray@decampo.org>
>> Authored: Sat Jan 28 07:41:48 2017 -0500
>> Committer: Ray DeCampo <ray@decampo.org>
>> Committed: Sat Jan 28 07:41:48 2017 -0500
>>
>>
>> ----------------------------------------------------------------------
>>  commons-numbers-complex/pom.xml                 |    1 -
>>  commons-numbers-core/pom.xml                    |   15 +
>>  .../commons/numbers/core/ArithmeticUtils.java   |  772 +++++++++++
>>  .../core/NumbersArithmeticException.java        |   54 +
>>  .../numbers/core/ArithmeticUtilsTest.java       |  782 ++++++++++++
>>  commons-numbers-fraction/LICENSE.txt            |  201 +++
>>  commons-numbers-fraction/NOTICE.txt             |    6 +
>>  commons-numbers-fraction/README.md              |   98 ++
>>  commons-numbers-fraction/pom.xml                |   58 +
>>  .../numbers/fraction/AbstractFormat.java        |  206 +++
>>  .../commons/numbers/fraction/BigFraction.java   | 1199
>> ++++++++++++++++++
>>  .../numbers/fraction/BigFractionField.java      |   83 ++
>>  .../numbers/fraction/BigFractionFormat.java     |  283 +++++
>>  .../commons/numbers/fraction/Fraction.java      |  664 ++++++++++
>>  .../fraction/FractionConversionException.java   |   51 +
>>  .../numbers/fraction/FractionException.java     |   44 +
>>  .../commons/numbers/fraction/FractionField.java |   82 ++
>>  .../numbers/fraction/FractionFormat.java        |  261 ++++
>>  .../fraction/FractionOverflowException.java     |   47 +
>>  .../fraction/FractionParseException.java        |   38 +
>>  .../fraction/ProperBigFractionFormat.java       |  235 ++++
>>  .../numbers/fraction/ProperFractionFormat.java  |  227 ++++
>>  .../fraction/ZeroDenominatorException.java      |   53 +
>>  .../commons/numbers/fraction/package-info.java  |   22 +
>>  .../numbers/fraction/BigFractionFieldTest.java  |   43 +
>>  .../numbers/fraction/BigFractionFormatTest.java |  330 +++++
>>  .../numbers/fraction/BigFractionTest.java       |  635 ++++++++++
>>  .../numbers/fraction/FractionFieldTest.java     |   43 +
>>  .../numbers/fraction/FractionFormatTest.java    |  349 +++++
>>  .../commons/numbers/fraction/FractionTest.java  |  625 +++++++++
>>  commons-numbers-quaternion/pom.xml              |    1 -
>>  pom.xml                                         |   20 +-
>>  32 files changed, 7525 insertions(+), 3 deletions(-)
>>
>> ----------------------------------------------------------------------
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message