commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stain <...@git.apache.org>
Subject [GitHub] commons-rdf issue #30: COMMONSRDF-51 language tags compared lower case
Date Thu, 26 Jan 2017 14:44:58 GMT
Github user stain commented on the issue:

    https://github.com/apache/commons-rdf/pull/30
  
    Thanks @afs , that makes sense, `JenaGraphImpl` was indeed using `graph.delete()`. 
    
    I have fixed in both `JenaGraphImpl` and `JenaDatasetImpl`.  See comment - do you think
there is much performance gain from not splitting into pattern but passing the original Jena
Triple (safe only when there's no Literal object with langtag) - or shall we always use the
pattern?
    
    (e.g. would Jena TDB do things like get an internal Triple row ID out of the jena `Triple`
for faster delete?)
    
    I added tests for Dataset that reveals that statements in default graph come back from
Jena in the named graph `<urn:x-arq:DefaultGraph>` - that's a separate bug in `JenaDatasetImpl`
and the converters - we should represent that always as `Optional.empty()` in Commons RDF
land.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message