commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] commons-compress issue #13: BZip2: Use BitInputStream
Date Wed, 18 Jan 2017 16:32:21 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/commons-compress/pull/13
  
    Some rough comparisons for larger files would be a good indicator.
    
    The existing code is pretty ugly because this seemed to be necessary for acceptable performance
back then. "Back then" is JDK 1.3 or 1.4, though. Another aspect was that the code stayed
close to libbzip2's C implementation which in theory would have allowed us to port changes
- which I don't think has ever happened.
    
    Do you think you could create separate PRs for your javadoc typo fixes and making methods
static in GZIP? They are separate commits, which is most important to me, but separate PRs
looks even cleaner :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message