commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [CANCE][VOTE][LAZY] Release Commons Parent POM 42 based on RC1
Date Sun, 04 Dec 2016 01:27:11 GMT
They won't be signed or hashed if the files are not "attached" because then
they are not officially output artifacts of the build, and won't be
deployed.

You can run hashing and signing plugins manually, but then the ordering of
the phases matter; to avoid a race condition where the assembly plugin is
run after the signing or hashing.

Here's how we tried that in earlier release of Commons RDF:

https://github.com/apache/incubator-commonsrdf/blob/0.2.0-incubating/pom.xml#L446


note that this was buggy in other ways, e.g. it deployed .sha1.md5 etc and
I think was meant more as a convenience for the RM than for deployment. If
done on a detached file that should avoid double signatures. (My view is
that the source distros SHOULD be deployed - but of course only for the
main distro, not per module.

Maven assembly plugin etc can be hard.. should we ask on users@maven ..?

On 3 Dec 2016 4:41 pm, "Gary Gregory" <garydgregory@gmail.com> wrote:

So, when I run:

mvn clean deploy -Duser.name=ggregory -Prelease -Ptest-deploy

The zip and gz files are created but not signed or hashed.

Thoughts?

Gary


On Sat, Dec 3, 2016 at 2:53 AM, Stian Soiland-Reyes <stain@apache.org>
wrote:

> I would prefer the source distribution to also be deployed in Maven
> Central, as most Maven projects now do through the Apache super pom (but
> then called -source-release). This means the Maven distribution for a
> particular version should be completely reproducible without having to
hunt
> around the archive.apache.org (which is discouraged for direct downloads)
> and have slight variations in paths and filenames.
>
>
> We have not heard complaints from Sonatype to stop including the source
> distros - that would affect all Maven-using ASF project - their presence
> cause no harm.
>
>
> When reviewing an RC a -src.tar.gz in the repo also makes it very easy to
> check that the deployed version matches src dist (barring deliberate
fraud)
> - for the rng RC I had to instead check each of the -sources.jar (which
are
> not guaranteed to be compilable).
>
>
> Another matter is the -bin releases (they are just aggregates of jars
> already deployed separately) and making sure there are not like .asc.asc
> extras. In a multi-module build only the top level distros should be made
-
> most ASF projects manage this in different ways.
>
> On 2 Dec 2016 2:07 am, "Charles Honton" <chas@honton.org> wrote:
>
> > Why do we expect the src zip to be present in the maven repository?  No
> > other commons project pushes the src zip/gz to maven central.
> >
> > If we want to supply src zip/gz as a convenience, why wouldn’t it be at
> > http://commons.apache.org/proper/ <http://commons.apache.org/proper/> as
> > all other components are?
> >
> > thanks,
> > chas
> >
> > > On Dec 1, 2016, at 9:15 AM, Gary Gregory <garydgregory@gmail.com>
> wrote:
> > >
> > > [editing subject]
> > >
> > > On Thu, Dec 1, 2016 at 9:14 AM, Gary Gregory <garydgregory@gmail.com>
> > wrote:
> > >
> > >> I am canceling this VOTE to deal with the missing src files.
> > >>
> > >> Gary
> > >>
> > >> On Thu, Dec 1, 2016 at 3:26 AM, Stian Soiland-Reyes <stain@apache.org
> >
> > >> wrote:
> > >>
> > >>> I did "mvn clean install -Prelease" from SVN and got in target/:
> > >>>
> > >>> commons-parent-42-SNAPSHOT-src.tar.gz
> > >>> commons-parent-42-SNAPSHOT-src.zip
> > >>>
> > >>> however they were not installed to the Maven repository, because the
> > >>> pom says "<attach>false</attach>"
> > >>>
> > >>>
> > >>>
> > >>> On 30 November 2016 at 19:04, Gary Gregory <garydgregory@gmail.com>
> > >>> wrote:
> > >>>> On Wed, Nov 30, 2016 at 1:34 AM, Stian Soiland-Reyes <
> > stain@apache.org>
> > >>>> wrote:
> > >>>>
> > >>>>> Just a thing I noticed..
> > >>>>>
> > >>>>> In https://dist.apache.org/repos/dist/release/commons/commons-
> > >>>>> parent/commons-parent-41/
> > >>>>> and before we had a -src.tar.gz and -src.zip
> > >>>>> (just like any other
> > >>>>>
> > >>>>> while your candidate in
> > >>>>> https://dist.apache.org/repos/dist/dev/commons/commons-
> > parent/42-RC1/
> > >>>>> is just the deployed pom file and so can't as easily be "built"
or
> > >>>>> installed.
> > >>>>>
> > >>>>> Not a blocker for me personally, but it would be good if we
can
> keep
> > >>>>> the parent similar to the other components, even if it doesn't
have
> > >>>>> any source code. For instance Debian packages Commons parent.
> > >>>>>
> > >>>>
> > >>>> I looks like we started providing the src zip/gz with version 40
> only.
> > >>> Crud!
> > >>>>
> > >>>> I'm not sure why the assembly plugin did not kick in.
> > >>>>
> > >>>> Can someone take a look?
> > >>>>
> > >>>> Thank you,
> > >>>> Gary
> > >>>>
> > >>>>
> > >>>>>
> > >>>>> On 30 November 2016 at 09:25, Stian Soiland-Reyes <
> stain@apache.org>
> > >>>>> wrote:
> > >>>>>> +1
> > >>>>>>
> > >>>>>> Checked:
> > >>>>>>
> > >>>>>> +1 Signatures, hashes
> > >>>>>> +1 tag matches repo matches dist
> > >>>>>> +1 No binaries
> > >>>>>> +1 Works with beanutils
> > >>>>>>
> > >>>>>> I got a bug when using it with Commons RDF for "mvn clean
package
> > >>>>> install",
> > >>>>>> related to the updated site-plugin:
> > >>>>>>
> > >>>>>> [ERROR] Failed to execute goal
> > >>>>>> org.apache.maven.plugins:maven-site-plugin:3.6:site
> (default-site)
> > >>> on
> > >>>>>> project commons-rdf-parent: Execution default-site of goal
> > >>>>>> org.apache.maven.plugins:maven-site-plugin:3.6:site failed:
A
> > >>> required
> > >>>>> class
> > >>>>>> was missing while executing
> > >>>>>> org.apache.maven.plugins:maven-site-plugin:3.6:site:
> > >>>>>> org/apache/maven/doxia/sink/impl/XhtmlBaseSink
> > >>>>>>
> > >>>>>> This was fixed by updating its doxia-module-markdown dependency
> from
> > >>> 1.6
> > >>>>> to
> > >>>>>> 1.7.
> > >>>>>>
> > >>>>>> With beanutils I tested the parent with "mvn clean install
site"
> and
> > >>> "mvn
> > >>>>>> release:prepare".
> > >>>>>>
> > >>>>>> On 27 November 2016 at 08:21, Gary Gregory <ggregory@apache.org>
> > >>> wrote:
> > >>>>>>> We have added some enhancements since Commons Parent
POM 41 was
> > >>>>> released,
> > >>>>>>> so I would like to release Commons Parent POM 42.
> > >>>>>>>
> > >>>>>>> Commons Parent POM 42 RC1 is available for review here:
> > >>>>>>> https://dist.apache.org/repos/dist/dev/commons/commons-paren
> > >>> t/42-RC1/
> > >>>>>>> (svn revision 17171)
> > >>>>>>>
> > >>>>>>> The tag is here:
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> http://svn.apache.org/repos/asf/commons/proper/commons-
> > >>>>> parent/tags/commons-parent-42-RC1/
> > >>>>>>> (svn revision 1771539)
> > >>>>>>> N.B. the SVN revision is required because SVN tags
are not
> > >>> immutable.
> > >>>>>>>
> > >>>>>>> Maven artifacts are here:
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> https://repository.apache.org/content/repositories/
> > >>>>> orgapachecommons-1221/org/apache/commons/commons-parent/42/
> > >>>>>>>
> > >>>>>>> These are the Maven artifacts and their hashes
> > >>>>>>>
> > >>>>>>> /org/apache/commons/commons-parent/42/commons-parent-42-site.xml
> > >>>>>>> (SHA1: a76e03e9059f31abc5e3c22f4e857366e689068f)
> > >>>>>>> /org/apache/commons/commons-parent/42/commons-parent-42-site
> > >>> .xml.asc
> > >>>>>>> (SHA1: 16b625891e404d95eb7688a99889dc499148d060)
> > >>>>>>> /org/apache/commons/commons-parent/42/commons-parent-42.pom
> > >>>>>>> (SHA1: b95e1096a4cf0d8bcd52740900a474b1e7f87dd1)
> > >>>>>>> /org/apache/commons/commons-parent/42/commons-parent-42.pom.asc
> > >>>>>>> (SHA1: 810728ac23f181f0f706ae0132bdb406288f5859)
> > >>>>>>>
> > >>>>>>> I built this with:
> > >>>>>>>
> > >>>>>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > >>>>>>> 2015-11-10T08:41:47-08:00)
> > >>>>>>> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> > >>>>>>> Java version: 1.8.0_112, vendor: Oracle Corporation
> > >>>>>>> Java home: C:\Program Files\Java\jdk1.8.0_112\jre
> > >>>>>>> Default locale: en_US, platform encoding: Cp1252
> > >>>>>>> OS name: "windows 7", version: "6.1", arch: "amd64",
family:
> "dos"
> > >>>>>>>
> > >>>>>>> The site was built with:
> > >>>>>>>
> > >>>>>>> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
> > >>>>>>> 2014-12-14T09:29:23-08:00)
> > >>>>>>> Maven home: E:\Java\apache-maven-3.2.5
> > >>>>>>> Java version: 1.7.0_79, vendor: Oracle Corporation
> > >>>>>>> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> > >>>>>>> Default locale: en_US, platform encoding: Cp1252
> > >>>>>>> OS name: "windows 7", version: "6.1", arch: "amd64",
family:
> > >>> "windows"
> > >>>>>>>
> > >>>>>>> [because Maven 3.3.9 gets an exception due to a binary
> compatiblity
> > >>>>> break
> > >>>>>>> in Slf4j.)
> > >>>>>>>
> > >>>>>>> Details of changes since 41 are in the release notes:
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> https://dist.apache.org/repos/dist/dev/commons/commons-
> > >>>>> parent/42-RC1/RELEASE-NOTES.txt
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> https://people.apache.org/~ggregory/commons-parent-42-
> > >>>>> RC1/site/changes-report.html
> > >>>>>>>
> > >>>>>>> Site:
> > >>>>>>> https://people.apache.org/~ggregory/commons-parent-42-RC1/site/
> > >>>>>>> (note some *relative* links are broken and the 42 directories
are
> > >>>>>>> not yet created - these will be OK once the site is
deployed)
> > >>>>>>>
> > >>>>>>> There is no Clirr Report (compared to 41) since there
is no Java
> > >>> code in
> > >>>>>>> this project.
> > >>>>>>>
> > >>>>>>> RAT Report:
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> https://people.apache.org/~ggregory/commons-parent-42-
> > >>>>> RC1/site/rat-report.html
> > >>>>>>> KEYS:
> > >>>>>>> https://www.apache.org/dist/commons/KEYS
> > >>>>>>>
> > >>>>>>> Please review the release candidate and vote.
> > >>>>>>>
> > >>>>>>> This lazy vote will close no sooner that 72 hours from
now, i.e.
> > >>>>> sometime
> > >>>>>>> after 09:00 UTC 30-November 2016
> > >>>>>>>
> > >>>>>>> [ ] +1 Release these artifacts
> > >>>>>>> [ ] +0 OK, but...
> > >>>>>>> [ ] -0 OK, but really should fix...
> > >>>>>>> [ ] -1 I oppose this release because...
> > >>>>>>>
> > >>>>>>> Thanks!
> > >>>>>>>
> > >>>>>>> Gary Gregory
> > >>>>>>>
> > >>>>>>> --
> > >>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
<
> > >>>>> ggregory@apache.org>
> > >>>>>>> Java Persistence with Hibernate, Second Edition
> > >>>>>>>
> > >>>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > >>>>> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > >>>>> linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b
> > >>> 1af9fe6a2b8>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> > >>>>> am2&o=1&a=1617290459>
> > >>>>>>> JUnit in Action, Second Edition
> > >>>>>>>
> > >>>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > >>>>> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > >>>>> linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac
> > >>> 902a24de418%22
> > >>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> > >>>>> am2&o=1&a=1935182021>
> > >>>>>>> Spring Batch in Action
> > >>>>>>>
> > >>>>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > >>>>> tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > >>>>> linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > >>>>> 7Blink_id%7D%7D%22%3ESpring%20Batch%20in%20Action>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> > >>>>> am2&o=1&a=1935182951>
> > >>>>>>> Blog: http://garygregory.wordpress.com
> > >>>>>>> Home: http://garygregory.com/
> > >>>>>>> Tweet! http://twitter.com/GaryGregory
> > >>>>>>
> > >>>>>> --
> > >>>>>> Stian Soiland-Reyes
> > >>>>>> http://orcid.org/0000-0001-9842-9718
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Stian Soiland-Reyes
> > >>>>> http://orcid.org/0000-0001-9842-9718
> > >>>>>
> > >>>>> ------------------------------------------------------------
> > ---------
> > >>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >>>>> For additional commands, e-mail: dev-help@commons.apache.org
> > >>>>>
> > >>>>>
> > >>>>
> > >>>>
> > >>>> --
> > >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > >>>> Java Persistence with Hibernate, Second Edition
> > >>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
> > >>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
> > >>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
> > >>>>
> > >>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> > >>> am2&o=1&a=1617290459>
> > >>>> JUnit in Action, Second Edition
> > >>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
> > >>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
> > >>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
> > 18%22>
> > >>>>
> > >>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> > >>> am2&o=1&a=1935182021>
> > >>>> Spring Batch in Action
> > >>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
> > >>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
> > >>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
> > >>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
> > >>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> > >>> am2&o=1&a=1935182951>
> > >>>> Blog: http://garygregory.wordpress.com
> > >>>> Home: http://garygregory.com/
> > >>>> Tweet! http://twitter.com/GaryGregory
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Stian Soiland-Reyes
> > >>> http://orcid.org/0000-0001-9842-9718
> > >>>
> > >>> ------------------------------------------------------------
> ---------
> > >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >>> For additional commands, e-mail: dev-help@commons.apache.org
> > >>>
> > >>>
> > >>
> > >>
> > >> --
> > >> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > >> Java Persistence with Hibernate, Second Edition
> > >> <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
> > >>
> > >> <http:////ir-na.amazon-adsystem.com/e/ir?t=
> garygregory-20&l=am2&o=1&a=
> > 1617290459>
> > >> JUnit in Action, Second Edition
> > >> <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
> 18%22
> > >
> > >>
> > >> <http:////ir-na.amazon-adsystem.com/e/ir?t=
> garygregory-20&l=am2&o=1&a=
> > 1935182021>
> > >> Spring Batch in Action
> > >> <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> > >> <http:////ir-na.amazon-adsystem.com/e/ir?t=
> garygregory-20&l=am2&o=1&a=
> > 1935182951>
> > >> Blog: http://garygregory.wordpress.com
> > >> Home: http://garygregory.com/
> > >> Tweet! http://twitter.com/GaryGregory
> > >>
> > >
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
> > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
> > >
> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > 1617290459>
> > > JUnit in Action, Second Edition
> > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
> > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
> 18%22
> > >
> > >
> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > 1935182021>
> > > Spring Batch in Action
> > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_
> > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
> > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
> > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
> > 1935182951>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> >
>



--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_
tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&
linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_
tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&
linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_
tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&
linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%
7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=
1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message