commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [complex][math-util] dependencies
Date Tue, 13 Dec 2016 16:01:35 GMT
Two bad code smells:

Do not use RuntimeException. Is IllegalArgumentException a possibility?

Don't throw the exception in the new method, you will loose the complier's
ability to warn you about certain code paths. You can create the exception
in a new method though.

Gary

On Dec 13, 2016 5:57 AM, "Eric Barnhill" <ericbarnhill@gmail.com> wrote:

> On Tue, Nov 29, 2016 at 8:48 PM, Gilles <gilles@harfang.homelinux.org>
> wrote:
>
>
> > In "Commons RNG", I completely dropped all custom-made exceptions.
> > I suggest you do the same here.
> > IMO, "simple", low-level, components can do with just throwing
> > runtime exceptions from the standard library (with a hard-coded
> > _English_ message).
>
>
> So, let's say three different methods in Quaternion throw a ZeroException
> right now.
>
> Are you happy with a coding practice of each method calling
>
> throw new RuntimeException("Zero Exception");
>
> or would it be preferable to write an additional method at the bottom,
>
> private static void zeroException() {
>     throw new RuntimeException("Zero Exception");
> }
>
> and call it three times?
>
> And if I do that, I should just tally up the different exceptions in the
> complex methods and have one more class, ComplexRuntimeExceptions.
>
> Barring any further objections, this is what I'll do.
>
> Eric
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message