commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Tompkins <chtom...@gmail.com>
Subject Re: [TEXT] Remove Commons Lang Dependency?
Date Sun, 18 Dec 2016 22:24:50 GMT


> On Dec 18, 2016, at 5:08 PM, Bruno P. Kinoshita <brunodepaulak@yahoo.com.br.INVALID>
wrote:
> 
> Hi Pascal,
> 
> I suspect we may need a few other methods in the future, but for now
> I agree we are not using much of [lang] in [text].
> 
> If you would like to release 1.0 without the [lang] dependency, and then
> we review it later whether we include it or not, I'd be fine with that.
> Though I'd be happy with a 1.0 release with shaded methods too. So I
> believe my vote would be a +0 :)
> 

I'm a +0 here as well. Feels like fewer dependencies is a better practice, but I'm ok with
including now or down the road. 

-Rob

> Hope that helps
> Bruno
> 
> 
> 
> 
> ----- Original Message -----
>> From: Pascal Schumacher <pascalschumacher@gmx.net>
>> To: Commons Developers List <dev@commons.apache.org>
>> Sent: Monday, 19 December 2016 7:06 AM
>> Subject: [TEXT] Remove Commons Lang Dependency?
>> 
>> Hello everybody,
>> 
>> commons-text currently depends on commons-lang. This dependency is 
>> included into the jar via the maven shade plugin.
>> 
>> Only two methods from lang are really needed:
>> 
>> StringUtils#containsAny
>> 
>> StringUtils#containsNone
>> 
>> As dependencies should be minimized I'm not sure if adding a dependency 
>> for two methods (less than 60 lines of code) is a good idea.
>> 
>> What do you think?
>> 
>> -Pascal
>> 
>> P.S.: I have created a pull request: 
>> https://github.com/apache/commons-text/pull/18/files to demonstrate the 
>> changes necessary for the removal.
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message