Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 13B95200BB4 for ; Tue, 18 Oct 2016 05:01:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1265B160AF0; Tue, 18 Oct 2016 03:01:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5A0D0160AEC for ; Tue, 18 Oct 2016 05:01:58 +0200 (CEST) Received: (qmail 92611 invoked by uid 500); 18 Oct 2016 03:01:52 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 92599 invoked by uid 99); 18 Oct 2016 03:01:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Oct 2016 03:01:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 95C461A078A for ; Tue, 18 Oct 2016 03:01:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id j78gEf2mcXsJ for ; Tue, 18 Oct 2016 03:01:49 +0000 (UTC) Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com [209.85.218.44]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6980A5FB20 for ; Tue, 18 Oct 2016 03:01:49 +0000 (UTC) Received: by mail-oi0-f44.google.com with SMTP id y2so236023479oie.0 for ; Mon, 17 Oct 2016 20:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=wGeTUqIjCeKFJ7SX8qa0AiuCuuBPRVsPbHeOOWSMHJE=; b=Wkzqn9Ga8C/AndtDAB6nATiITDxn9sYupDQ92gOvMZiim8UU95nG03BTK3nXZp9fvk b/gOwxy6JVVBP3pnKvK9jJKu3Zt/Qs8HuIFS1AoXb3KEpF7cJe4FjGJTE6jQ2C1DHUWi bpggO1XUE6bF++nmaTaRSzacnhdyFiPN4wCE7VhfxCetWa7XG9QZlOECG2pwfGwM30cx EF2aSxmxchkwA6Fik5O+/mUj/nNku3vSGD50YeeME9NjxNLnH6loTBiucEhfM7Hzkfre bu1kXjvxkYb7vwB+fQ3xzFzpFMqzGM5NQv9Tor7/aqEpNr+68dlJi/9pH9uAPZfvURj+ sdIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=wGeTUqIjCeKFJ7SX8qa0AiuCuuBPRVsPbHeOOWSMHJE=; b=E3aeWiIfLTTFgoWcBM1TvY0hQ8Tw6/8sViTLUJDl4iR/bOS2mvCR8OFfiMYvBXh+2Y bjfPb35qN8qbO+Vjn1YRcRMqglde1UteXlAgm9JxUoDKIEWQ709RLJtM4eV+ZAJETbcc rKxMTlFEUqtUXPhnvGbBsyzkqbEtUMHqXGzCQEJpPsGP/sE6OI2HsEWLH6qjFvdzFhUP qJg4zRrVqBUXnbYYXS1zTlRwEsvPRzJ1kzIqp+sMGKE9/0Bu/PXsI2y995mW7a4ORaT3 c6YZThJV8dofN0Dj6UEpDEVqzf6rl3NN6j1oiYwupnr+sE8Vp5v3DGCJ/+vbClugA+K1 +6Tw== X-Gm-Message-State: AA6/9Rm92N/1+Elfg/VZGsbppgAtK20tzkWb+U0KM78CNDweUOC1hxeY/DLtHZ8s/iC4Msh0S0zEI1YOTkeYMg== X-Received: by 10.202.98.130 with SMTP id w124mr441723oib.148.1476759708827; Mon, 17 Oct 2016 20:01:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.189 with HTTP; Mon, 17 Oct 2016 20:01:48 -0700 (PDT) In-Reply-To: References: <20161017165641.5151B3A0C69@svn01-us-west.apache.org> From: Gary Gregory Date: Mon, 17 Oct 2016 20:01:48 -0700 Message-ID: Subject: Re: svn commit: r1765341 - in /commons/proper/logging/trunk/src: changes/changes.xml main/java/org/apache/commons/logging/LogFactory.java main/java/org/apache/commons/logging/impl/SimpleLog.java To: Commons Developers List Content-Type: multipart/alternative; boundary=001a113d307edd065c053f1ae987 archived-at: Tue, 18 Oct 2016 03:01:59 -0000 --001a113d307edd065c053f1ae987 Content-Type: text/plain; charset=UTF-8 On Mon, Oct 17, 2016 at 2:25 PM, sebb wrote: > Also, java.io.IOException can be replaced by IOException ... > Fixed. > > On 17 October 2016 at 20:38, Benedikt Ritter wrote: > > Hello Gary, > > > > do you see a way to back this change with tests? > Probably with mocks... Gary > > > > Regards, > > Benedikt > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --001a113d307edd065c053f1ae987--