commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cagdasyelen <...@git.apache.org>
Subject [GitHub] commons-io pull request #20: [IO-499] FilenameUtils.directoryContains false ...
Date Sat, 24 Sep 2016 22:24:51 GMT
GitHub user cagdasyelen opened a pull request:

    https://github.com/apache/commons-io/pull/20

    [IO-499] FilenameUtils.directoryContains false positive issue 

    IO-499 bug has been fixed. 
    
    The old version was looking at if the child canonical path string starts with the parent's.

    However, it fails in the case of:
    
    .../top/foo
    .../top/foo2/b.txt
    
    since the directory path of b.txt starts with the same directory path with the one above
even though the second one is a different directory(foo2). This issue is resolved by comparing
the path strings of foo and foo2. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cagdasyelen/commons-io io499-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit fd95ccde6310bfee7314744d879c597882cb3381
Author: Cagdas Yelen <cagdas@utexas.edu>
Date:   2016-09-24T22:21:37Z

    [IO-499] FilenameUtils.directoryContains false positive issue is resolved

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message