commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [LANG] Methods introduced in LANG-1134
Date Sun, 18 Sep 2016 10:21:49 GMT
I agree; use notEquals, greaterThan, lessThan

'different' is ambiguous - does it mean notSame or notEquals?

On 17 September 2016 at 16:57, Gary Gregory <garydgregory@gmail.com> wrote:
> JUnit makes the distinction between "same" for the same object and "equals"
> and calling equals(), maybe this would help here.
>
> http://junit.org/junit4/javadoc/4.12/org/junit/Assert.html
>
> Gary
>
> On Sep 17, 2016 7:52 AM, "Benedikt Ritter" <britter@apache.org> wrote:
>
>> Hi,
>>
>> LANG-1134 introduced new methods to Validate. I'm not fond of the API as is
>> currently is. Here are my concerns:
>>
>> - When comparing numeral values usually we talk about greaterThan and
>> lessThan. The new API in Validate uses "smaller" and "greater"
>> - we have a method called "different" which checks that two reference are
>> not equal to each other. Who about calling that notEquals?
>>
>> Regards,
>> Benedikt
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message