Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Reply-To: <dennis.hamilton@acm.org>
From: "Dennis E. Hamilton" <dennis.hamilton@acm.org>
To: "'Commons Developers List'" <dev@commons.apache.org>
References: <5cd5b6f2f1604f319bd4b4a85d9e6788@git.apache.org> <f79f7a68410e4d258534843da1a86c3b@git.apache.org> <6ea6b3fbb1e94fe51a6901f1f0b55058@scarlet.be> <004201d1f012$c866e880$5934b980$@acm.org> <1ab96661ba80837f705e9da386ddc748@scarlet.be> <19c228d5-d936-99c7-7f4d-dbae44c38499@apache.org> <86f9d1d238a4628299947306d772fe34@scarlet.be> <49823797-81ac-312a-eb22-1b78e2d9fd2b@apache.org> <3a9e2736de8e062a95f9efb9163ea3a4@scarlet.be>
In-Reply-To: <3a9e2736de8e062a95f9efb9163ea3a4@scarlet.be>
Subject: RE: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8
Date: Mon, 8 Aug 2016 09:57:48 -0700
Organization: NuovoDoc
Message-ID: <00df01d1f196$01f002b0$05d00810$@acm.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIXm0VEs5z7JOLjvextAi8R0GTilAFbusHlAjkLsUkC5VSmlQI8Um1wAu83GbUA13DajAKPdthEAavZngWfLiHcgA==
Content-Language: en-us
archived-at: Mon, 08 Aug 2016 16:58:24 -0000

From the peanut gallery, in-line.

> -----Original Message-----
> From: Gilles [mailto:gilles@harfang.homelinux.org]
> Sent: Monday, August 8, 2016 08:50
> To: dev@commons.apache.org
> Subject: Re: [5/7] [math] Fix "FastMath#round(..)" to comply to =
changed
> contract of "Math#round()" in Java 8
>=20
> On Mon, 8 Aug 2016 16:40:04 +0200, Emmanuel Bourg wrote:
> > Le 8/08/2016 =C3=A0 16:22, Gilles a =C3=A9crit :
> >
> >> There are pro and contra; IMO, saving a few characters is not worth
> >> wondering upon reading whether "assertEquals" is from (JUnit)
> >> "Assert"
> >> or Commons Math "TestUtils".
> >
> > Seriously, there is little doubt that "assertEquals" comes from =
JUnit
> > in
> > a FooTest class. Everybody is used to that.
[orcmid]=20

It is the presumption of tacit knowledge, in an ever-expanding ring, =
that complicates the on-ramp for newcomers, until they manage to gulp =
down all of the kool-aid and become perpetrators themselves. =20

>=20
> My point was that there exists "TestUtils.assertEquals": also for use
> in a unit test class!
> Someone might want to "import static" those too.  In some files
> "Assert"
> would be implied, and in others "TestUtils".  [No big deal: just what
> you gain somewhere you loose somewhere else.]
[orcmid]=20

Except it is another dependency that someone has to be careful to check, =
and we're not talking about small test files here.

>=20
> I have no problem deciding that static import of Junit's Assert =
methods
> is allowed.  But let's be clear that it does extend to other classes.
>=20
> >> When people get accustomed to git, they won't see it as a
> >> constraint,
> >> rather as second nature.
> >
> > I'm accustomed to Git and I see this as a constraint that I don't
> > have
> > the time to deal with.
>=20
> Hence, you assume that reviewers are either not necessary, or that
> they their time is worth less than yours.
>=20
> We can (have to, actually) understand that long-time committers
> will take a short-cut sometimes, but whenever it happens it should
> not be a massive commit.  Otherwise anything goes.  I hope that you
> can agree that it should not be advertised as good practice.
[orcmid]=20

+1 with regard to paying attention to sustainability and community.

>=20
>=20
> Regards,
> Gilles
>=20
> >
> > Emmanuel Bourg
> >
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org