commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [BCEL] Need advice on GitHub PR
Date Mon, 29 Aug 2016 06:33:10 GMT
Hello Mark,

Mark Roberts <markro@cs.washington.edu> schrieb am Sa., 27. Aug. 2016 um
18:19 Uhr:

> This sounds very similar to the previous attempt to do this that broke our
> tool Daikon.  Please see https://issues.apache.org/jira/browse/BCEL-79
> and make sure we're not doing this incorrectly again.
>

How do can we make sure we don't break Daikon? Do you see a way to provide
integration tests for that?


>
> Unfortunately, I do not have the time right now to do a full review.  If
> no one else volunteers, let me know and I'll see what I can do.
>

I've reviewed this to a point where it could be integrated from a code
style PoV. But I don't have the domain knowledge to judge whether this is
the right thing to do. So some advice from an expert would be appreciated.

Benedikt


>
> Thanks,
> Mark
>
> > -----Original Message-----
> > From: Benedikt Ritter [mailto:britter@apache.org]
> > Sent: Saturday, August 27, 2016 7:27 AM
> > To: Commons Developers List
> > Subject: [BCEL] Need advice on GitHub PR
> >
> > Hello everybody,
> >
> > we have this PR [1] which has been pending for a while. Now we only have
> one
> > comment left [2], which I can't really get my head around (probably due
> to missing
> > experience with byte code generation and stuff :o)
> >
> > Does anybody have time to take a look?
> >
> > Best regards,
> > Benedikt
> >
> > [1] https://github.com/apache/commons-bcel/pull/10
> > [2] https://github.com/apache/commons-bcel/pull/10#discussion_r75886503
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message