commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles <gil...@harfang.homelinux.org>
Subject [rng] Re: commons-rng git commit: Do not output checkstyle error to the console.
Date Wed, 17 Aug 2016 21:17:08 GMT
Artem,

You have introduced spurious blank spaces.

You should perform
$ git diff --check

You committed a file ("checkstyle.xml") unrelated to the
commit message...

Regards,
Gilles

On Wed, 17 Aug 2016 21:00:17 +0000 (UTC), bartem@apache.org wrote:
> Repository: commons-rng
> Updated Branches:
>   refs/heads/master cf0bbf9a2 -> b8f28ccbe
>
>
> Do not output checkstyle error to the console.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
> Commit: 
> http://git-wip-us.apache.org/repos/asf/commons-rng/commit/b8f28ccb
> Tree: 
> http://git-wip-us.apache.org/repos/asf/commons-rng/tree/b8f28ccb
> Diff: 
> http://git-wip-us.apache.org/repos/asf/commons-rng/diff/b8f28ccb
>
> Branch: refs/heads/master
> Commit: b8f28ccbe105db1b5409750aed2e28fbcaab01f4
> Parents: cf0bbf9
> Author: Artem Barger <artem@bargr.net>
> Authored: Wed Aug 17 23:58:47 2016 +0300
> Committer: Artem Barger <artem@bargr.net>
> Committed: Wed Aug 17 23:58:47 2016 +0300
>
> 
> ----------------------------------------------------------------------
>  checkstyle.xml | 16 ++++++++--------
>  pom.xml        |  2 --
>  2 files changed, 8 insertions(+), 10 deletions(-)
> 
> ----------------------------------------------------------------------
>
>
> 
> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/b8f28ccb/checkstyle.xml
> 
> ----------------------------------------------------------------------
> diff --git a/checkstyle.xml b/checkstyle.xml
> index 6582428..8616b73 100644
> --- a/checkstyle.xml
> +++ b/checkstyle.xml
> @@ -38,7 +38,7 @@
>
>      <!-- Must have class / interface header comments -->
>      <module name="JavadocType"/>
> -
> +
>       <!-- Require method javadocs, allow undeclared RTE -->
>      <module name="JavadocMethod">
>        <property name="allowUndeclaredRTE" value="true"/>
> @@ -48,7 +48,7 @@
>
>      <!-- Require field javadoc -->
>      <module name="JavadocVariable"/>
> -
> +
>      <!-- No public fields -->
>      <module name="VisibilityModifier">
>         <property name="protectedAllowed" value="true"/>
> @@ -56,7 +56,7 @@
>
>      <!-- Require hash code override when equals is -->
>      <module name="EqualsHashCode"/>
> -
> +
>      <!-- Disallow unnecessary instantiation of Boolean, String -->
>      <module name="IllegalInstantiation">
>        <property name="classes" value="java.lang.Boolean, 
> java.lang.String"/>
> @@ -64,7 +64,7 @@
>
>      <!-- Required for SuppressionCommentFilter below -->
>      <module name="FileContentsHolder"/>
> -
> +
>      <!--  Import should be explicit, really needed and only from
> pure java packages -->
>      <module name="AvoidStarImport" />
>      <module name="UnusedImports" />
> @@ -85,14 +85,14 @@
>          <property name="ignoreConstructorParameter" value="true" />
>          <property name="ignoreSetter" value="true" />
>      </module>
> -
> +
>      <!-- No trailing whitespace -->
>      <module name="Regexp">
>        <property name="format" value="[ \t]+$"/>
>        <property name="illegalPattern" value="true"/>
>        <property name="message" value="Trailing whitespace"/>
>      </module>
> -
> +
>      <!-- No System.out.println() statements -->
>      <module name="Regexp">
>        <!-- no sysouts -->
> @@ -122,7 +122,7 @@
>
>      <!-- Don't use = or != for string comparisons -->
>      <module name="StringLiteralEquality" />
> -
> +
>     <!-- Don't declare multiple variables in the same statement -->
>      <module name="MultipleVariableDeclarations" />
>
> @@ -149,7 +149,7 @@
>
>    <!-- Require files to end with newline characters -->
>    <module name="NewlineAtEndOfFile"/>
> -
> +
>    <!-- Require package javadoc -->
>    <module name="JavadocPackage"/>
>
>
> 
> http://git-wip-us.apache.org/repos/asf/commons-rng/blob/b8f28ccb/pom.xml
> 
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 19f12ed..0e3d4ed 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -302,9 +302,7 @@
>                  <configuration>
>
> <includeTestSourceDirectory>true</includeTestSourceDirectory>
>                      <configLocation>checkstyle.xml</configLocation>
> -                    <consoleOutput>true</consoleOutput>
>                      
> <logViolationsToConsole>true</logViolationsToConsole>
> -                    <resourceIncludes>**/*.java</resourceIncludes>
>                  </configuration>
>              </plugin>
>          </plugins>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message