commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [io-480] Query
Date Thu, 21 Jul 2016 04:15:26 GMT
Hi Rajiv,

I added a "[Deprecated]" to the class comment for the closeQuietly() list
item.

I did not use the patch to use "Please note, that IOExceptions are caught
but any RuntimeExceptions can be thrown from the close() method."

It seems to me that a RuntimeException can be thrown from the guts of any
method, especially like a close-like method, so I am not sure I see the
value here.

Perhaps others in the community feel otherwise and I invite them to make a
suitable change. I just do not see it needed from my POV.

Thank you,
Gary

On Mon, Jul 18, 2016 at 12:57 PM, Rajiv Jain <rajivpjs@gmail.com> wrote:

> Thanks Gary. I will be patient.
>
> Thanks for replying.
>
> Rajiv
>
> > On 18 Jul 2016, at 20:56, Gary Gregory <garydgregory@gmail.com> wrote:
> >
> > Hello Rajiv,
> >
> > We are all volunteers working on a large project with many components
> with
> > different levels of activity. Please be patient. Hopefully someone will
> > take a look at your request soon.
> >
> > Gary
> >
> > On Mon, Jul 18, 2016 at 10:16 AM, Rajiv Jain <rajivpjs@gmail.com
> <mailto:rajivpjs@gmail.com>> wrote:
> >
> >> Hi
> >>
> >> I have been working on the Apache Maven project as a contributor
> recently.
> >> I don’t know whether it is any different for Apache Commons IO.
> >>
> >> The procedure for Apache Maven contributions are:
> >>
> >> a) Choose a Jira ticket to work on
> >> b) Fork the project
> >> 3) Make changes
> >> 4) Apply a pull request
> >>
> >> For the issues that I have worked on, pull requests are reviewed.
> >>
> >> A few days ago, I worked on the Commons IO for IO-480 and removed some
> >> Java documentation within the class files but no one has reviewed it.
> Is it
> >> the same process or have I missed something? The pull request is located
> >> here: https://github.com/apache/commons-io/pull/14 <
> >> https://github.com/apache/commons-io/pull/14 <
> https://github.com/apache/commons-io/pull/14>>
> >>
> >> In addition, if I would like to work on Apache Commons project where is
> >> the best place I can start. As, I looked at the Jira tickets and there
> are
> >> in open state and when looking into the code they have already been
> fixed.
> >>
> >> Thanks.
> >>
> >> Regards,
> >> Rajiv
> >
> >
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com <mailto:garydgregory@gmail.com> |
> ggregory@apache.org <mailto:ggregory@apache.org>
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/ <http://www.manning.com/bauer3/>>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/ <
> http://www.manning.com/tahchiev/>>
> > Spring Batch in Action <http://www.manning.com/templier/ <
> http://www.manning.com/templier/>>
> > Blog: http://garygregory.wordpress.com <
> http://garygregory.wordpress.com/>
> > Home: http://garygregory.com/ <http://garygregory.com/>
> > Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message