commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
Date Tue, 05 Jul 2016 18:06:52 GMT
Well, all of my tests are OK.

Building from src zip is OK MD5, SHA1, ASC OK.

Builds fine with Maven 3.4.0-SNAPSHOT and Java 7 on Windows 7 64 bit.

It's a shame that it does not build on Oliver's Windows 10 (and probably
other set ups) due to the bug in JDKGenericDumpTestCase *I* introduced
(which affects only some Windows builds.)

I do not feel good about releasing a src package that we know cannot be
built on a particular set up.

So I am going to be -0 for now.

Gary

On Sun, Jul 3, 2016 at 3:55 PM, Gary Gregory <garydgregory@gmail.com> wrote:

> Arg! That looks like an invalid assumption in the test code I wrote. I
> made an adjustment in trunk. Can you try it again from trunk?
>
> Thank you,
> Gary
>
> On Sun, Jul 3, 2016 at 12:39 PM, Oliver Heger <
> oliver.heger@oliver-heger.de> wrote:
>
>> Ok, here is the full stack trace. The German error message means that
>> the system cannot find the specified file.
>>
>> What kind of registry information do you need?
>>
>> Oliver
>>
>>
>> -------------------------------------------------------------------------------
>> Test set: org.apache.bcel.generic.JDKGenericDumpTestCase
>>
>> -------------------------------------------------------------------------------
>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.359
>> sec <<< FAILURE! - in org.apache.bcel.generic.JDKGenericDumpTestCase
>> initializationError(org.apache.bcel.generic.JDKGenericDumpTestCase)
>> Time elapsed: 0.015 sec  <<< ERROR!
>> com.sun.jna.platform.win32.Win32Exception: Das System kann die
>> angegebene Datei nicht finden.
>>         at
>>
>> org.apache.bcel.generic.JDKGenericDumpTestCase.findJavaHomesOnWindows(JDKGenericDumpTestCase.java:84)
>>         at
>>
>> org.apache.bcel.generic.JDKGenericDumpTestCase.findJavaHomesOnWindows(JDKGenericDumpTestCase.java:77)
>>         at
>>
>> org.apache.bcel.generic.JDKGenericDumpTestCase.findJavaHomes(JDKGenericDumpTestCase.java:65)
>>         at
>>
>> org.apache.bcel.generic.JDKGenericDumpTestCase.data(JDKGenericDumpTestCase.java:60)
>>
>>
>>
>> Am 03.07.2016 um 17:18 schrieb Gary Gregory:
>> > What are stack traces for the errors? All the tests pass for me on
>> Windows
>> > 7 with this RC. I added some test code to find all Java installs since
>> the
>> > last RC. I see you are on Windows 10, so I am curious as to your
>> failures,
>> > stack traces and windows registry set up.
>> >
>> > Gary
>> > On Jul 3, 2016 7:50 AM, "Oliver Heger" <oliver.heger@oliver-heger.de>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> when building from the source distribution with both Java 1.7 and 1.8 I
>> >> get the following test failure:
>> >>
>> >> Results :
>> >>
>> >> Tests in error:
>> >>
>> >>
>> >>
>> JDKGenericDumpTestCase.data:60->findJavaHomes:65->findJavaHomesOnWindows:77->findJavaHomesOnWindows:84
>> >> ยป Win32
>> >>
>> >> Tests run: 102, Failures: 0, Errors: 1, Skipped: 0
>> >>
>> >> Does anybody else see this? I do not remember this failure with the
>> last
>> >> RC. Below is my platform:
>> >>
>> >> c:\data\dev\projects\OpenSource\bcel\bcel-6.0-src>mvn -version
>> >> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> >> 2015-11-10T17:41:47+01:00)
>> >> Maven home: c:\data\dev\tools\apache-maven-3.3.9\bin\..
>> >> Java version: 1.8.0_66, vendor: Oracle Corporation
>> >> Java home: C:\Program Files\Java\jdk1.8.0_66\jre
>> >> Default locale: de_DE, platform encoding: Cp1252
>> >> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
>> >>
>> >> Oliver
>> >>
>> >> Am 02.07.2016 um 20:52 schrieb Benedikt Ritter:
>> >>> Hi,
>> >>>
>> >>> I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
>> >> compared
>> >>> to RC6 are:
>> >>>
>> >>> - restored binary compatibility to a greater degree
>> >>> - fixed issue BCEL-262
>> >>>
>> >>> BCEL 6.0 RC7 is available for review here:
>> >>> https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
>> >> 14251)
>> >>>
>> >>> The tag is here:
>> >>>
>> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC7/
>> >> (svn
>> >>> revision 1751084)
>> >>>
>> >>> Maven artifacts are here:
>> >>>
>> >>
>> https://repository.apache.org/content/repositories/orgapachecommons-1181/org/apache/bcel/bcel/6.0/
>> >>>
>> >>> These are the Maven artifacts and their hashes
>> >>>
>> >>> bcel-6.0-javadoc.jar
>> >>>   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
>> >>> bcel-6.0-sources.jar
>> >>>   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
>> >>> bcel-6.0-test-sources.jar
>> >>>   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
>> >>> bcel-6.0-tests.jar
>> >>>   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
>> >>> bcel-6.0.jar
>> >>>   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
>> >>> bcel-6.0.pom
>> >>>   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
>> >>>
>> >>> I have tested this with JDK 7, 8 using Maven 3.3.9.
>> >>>
>> >>> Details of changes since 1.1 are in the release notes:
>> >>>
>> https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>> >>>
>> >>
>> http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-report.html
>> >>>
>> >>> Site:
>> >>>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
>> >>> (note some *relative* links are broken and the 6.0 directories are not
>> >> yet
>> >>> created - these will be OK once the site is deployed)
>> >>>
>> >>> Clirr Report (compared to 5.2):
>> >>>
>> http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.html
>> >>>
>> >>> Note that Clirr reports several errors.
>> >>> These are considered OK for the reasons stated below.
>> >>> These exceptions are also noted in the Changes and Release Notes.
>> >>>
>> >>> Errors reported:
>> >>> - methods added to org.apache.bcel.classfile.Visitor interface: OK
>> >> because
>> >>> that does not affect binary compatibility.
>> >>> - Removed java.io.Serializable from all classes: OK, because we don't
>> >>> expect anybody to rely on serialization for BCEL classes
>> >>> - Return type of method 'public java.lang.Object getElementAt(int)'
>> has
>> >>> been changed to java.lang.String in class
>> >>> org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this
>> class
>> >>> is part of an UI application and for this reason should only used by
>> >> Swing.
>> >>>
>> >>> RAT Report:
>> >>>
>> http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-report.html
>> >>>
>> >>> KEYS:
>> >>>   https://www.apache.org/dist/commons/KEYS
>> >>>
>> >>> Please review the release candidate and vote. This vote will close no
>> >>> sooner that 72 hours from now, i.e. sometime after 21:00 CEST 05-July
>> >> 2016
>> >>>
>> >>> [ ] +1 Release these artifacts
>> >>> [ ] +0 OK, but...
>> >>> [ ] -0 OK, but really should fix...
>> >>> [ ] -1 I oppose this release because...
>> >>>
>> >>> Thanks!
>> >>> Benedikt
>> >>>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message