commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts" <mar...@cs.washington.edu>
Subject RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
Date Wed, 06 Jul 2016 16:16:16 GMT
Hmm - now I'm thinking the code for InvokeInstruction is not correct.  The override method
getClassName was added, but my patch was not applied to the added code.  I have attached the
diff.

Sorry for not catching this the first time.

Thank you,
Mark


> -----Original Message-----
> From: Mark Roberts [mailto:markro@cs.washington.edu]
> Sent: Wednesday, July 06, 2016 6:57 AM
> To: 'Commons Developers List'
> Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> 
> The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should be exactly
> the opposite.  The override was added to InvokeInstruction because an array
> IS a legal operand.  The code is correct, the throw has been removed.
> 
> Mark
> 
> > -----Original Message-----
> > From: Benedikt Ritter [mailto:britter@apache.org]
> > Sent: Tuesday, July 05, 2016 2:17 AM
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >
> > This vote is still pending and nobody has voted so far. Please review
> > this RC and cast your votes!
> >
> > Thank you!
> > Benedikt
> >
> > Benedikt Ritter <britter@apache.org> schrieb am Sa., 2. Juli 2016 um
> > 20:52 Uhr:
> >
> > > Hi,
> > >
> > > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
> > > compared to RC6 are:
> > >
> > > - restored binary compatibility to a greater degree
> > > - fixed issue BCEL-262
> > >
> > > BCEL 6.0 RC7 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
> > > 14251)
> > >
> > > The tag is here:
> > >
> >
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC
> > 7/
> > > (svn revision 1751084)
> > >
> > > Maven artifacts are here:
> > >
> https://repository.apache.org/content/repositories/orgapachecommons-
> > 11
> > > 81/org/apache/bcel/bcel/6.0/
> > >
> > > These are the Maven artifacts and their hashes
> > >
> > > bcel-6.0-javadoc.jar
> > >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > > bcel-6.0-sources.jar
> > >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > > bcel-6.0-test-sources.jar
> > >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > > bcel-6.0-tests.jar
> > >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > > bcel-6.0.jar
> > >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > > bcel-6.0.pom
> > >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> > >
> > > I have tested this with JDK 7, 8 using Maven 3.3.9.
> > >
> > > Details of changes since 1.1 are in the release notes:
> > >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> > NOTES.txt
> > >
> > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-
> > report.ht
> > > ml
> > >
> > > Site:
> > >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > > (note some *relative* links are broken and the 6.0 directories are
> > > not yet created - these will be OK once the site is deployed)
> > >
> > > Clirr Report (compared to 5.2):
> > >
> > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.ht
> > > ml
> > >
> > > Note that Clirr reports several errors.
> > > These are considered OK for the reasons stated below.
> > > These exceptions are also noted in the Changes and Release Notes.
> > >
> > > Errors reported:
> > > - methods added to org.apache.bcel.classfile.Visitor interface: OK
> > > because that does not affect binary compatibility.
> > > - Removed java.io.Serializable from all classes: OK, because we
> > > don't expect anybody to rely on serialization for BCEL classes
> > > - Return type of method 'public java.lang.Object getElementAt(int)'
> > > has been changed to java.lang.String in class
> > > org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this
> > > class is part of an UI application and for this reason should only
> > > used by
> > Swing.
> > >
> > > RAT Report:
> > >
> > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-
> report.html
> > >
> > > KEYS:
> > >   https://www.apache.org/dist/commons/KEYS
> > >
> > > Please review the release candidate and vote. This vote will close
> > > no sooner that 72 hours from now, i.e. sometime after 21:00 CEST
> > > 05-July
> > > 2016
> > >
> > > [ ] +1 Release these artifacts
> > > [ ] +0 OK, but...
> > > [ ] -0 OK, but really should fix...
> > > [ ] -1 I oppose this release because...
> > >
> > > Thanks!
> > > Benedikt
> > >


Mime
View raw message