Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
Sender: sebbaz@gmail.com
In-Reply-To: <67ef2ba959fb414a9316b496b96b1bf7@git.apache.org>
References: <67ef2ba959fb414a9316b496b96b1bf7@git.apache.org>
From: sebb AT ASF <sebb@apache.org>
Date: Wed, 29 Jun 2016 11:27:28 +0100
Message-ID: <CAOGo0VauQQFxfDMgV_QP5BF7faeDMJMYj1L45KDAq6jhXuaCTg@mail.gmail.com>
Subject: Re: commons-crypto git commit: Fallback no longer exists
To: CommonsDev <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8
archived-at: Wed, 29 Jun 2016 10:27:34 -0000

This compile error was not picked up because the Benchmark class is
only compiled if the -Pbenchmark profile is used.

The class cannot currently be compiled in normal mode because it
depends on JMH which is only included as a test dependency by the
profile.

I'm wondering whether the test dependency on jmh should be made unconditional?
This would allow compilation during the test phase.
The profile would still be needed to run the benchmark itself.

Would there be any disadvantages to always depending on JMH?

On 29 June 2016 at 11:21,  <sebb@apache.org> wrote:
> Repository: commons-crypto
> Updated Branches:
>   refs/heads/master 9e7f040b1 -> 8a8bcb0a3
>
>
> Fallback no longer exists
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/8a8bcb0a
> Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/8a8bcb0a
> Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/8a8bcb0a
>
> Branch: refs/heads/master
> Commit: 8a8bcb0a3293597b306b49ea86f1e592b8b00b47
> Parents: 9e7f040
> Author: Sebb <sebb@apache.org>
> Authored: Wed Jun 29 11:20:58 2016 +0100
> Committer: Sebb <sebb@apache.org>
> Committed: Wed Jun 29 11:20:58 2016 +0100
>
> ----------------------------------------------------------------------
>  src/test/java/org/apache/commons/crypto/CryptoBenchmark.java | 2 --
>  1 file changed, 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/8a8bcb0a/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java
> ----------------------------------------------------------------------
> diff --git a/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java b/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java
> index b1bd753..9e10311 100644
> --- a/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java
> +++ b/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java
> @@ -173,8 +173,6 @@ public class CryptoBenchmark {
>      private CryptoCipher getCipher(String className) throws Exception {
>          Properties properties = new Properties();
>          properties.setProperty(ConfigurationKeys.CIPHER_CLASSES_KEY, className);
> -        properties.setProperty(ConfigurationKeys.ENABLE_FALLBACK_ON_NATIVE_FAILED_KEY, "false");
> -
>          CryptoCipher cipher = CryptoCipherFactory.getInstance("AES/CBC/PKCS5Padding", properties);
>          Assert.assertEquals(className, cipher.getClass().getCanonicalName());
>          return cipher;
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org