Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <CAJZRQKxg2GXFcBzJuPWfFr3Nxa4V0r4MTzCc8BoH=J9EamDRnw@mail.gmail.com>
References: <CAJZRQKxg2GXFcBzJuPWfFr3Nxa4V0r4MTzCc8BoH=J9EamDRnw@mail.gmail.com>
From: Stian Soiland-Reyes <stain@apache.org>
Date: Mon, 27 Jun 2016 18:21:45 +0100
Message-ID: <CAMBJEmXL++NZem5uk+HQG4hvXZw=fppJfaYnEXHi7m7_0pugig@mail.gmail.com>
Subject: Re: Reformatting commons-io to single code style ?
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8
archived-at: Mon, 27 Jun 2016 17:22:09 -0000

+1 if the code is messy or inconsistent, -0 if it's already OK.

Personally I wouldn't do the whole code, just tidy in a separate
commit per file before editing it.

If you do all of them, then we should also add the agreed
checkstyle.xml or equivalent code style file, so that it's easy to
keep compliance. The code style should be minimal, e.g. mainly just
get decent indentation and have consistent line-breaks in the method
declaration, but not care too much about things like how if/else
blocks are done or the number of () in a && check.

On 27 June 2016 at 09:09, Kristian Rosenvold <krosenvold@apache.org> wrote:
> This has probably been discussed a million times before, so I'll keep
> it short. commons-io has wonderfully inconsistent code style even
> within individual code files.
>
> Once the move to git completes, I'd like to reformat the entire code
> base (including javadoc) to a single style. I don't really care which
> style, my OCD is about consistency, not about which particular style
> is in use :)
>
> (Is there any kind of intelliJ code style file for commons ?)
>
> Sorry for disturbing the hornets :)
>
> Kristian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


-- 
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org