Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <CAG3-T36MqMunE-M_m0jV+hUegaWtSdLoUyE19orf9NfkKYQOtw@mail.gmail.com>
References: <CAG3-T36MHS22qzuHOGsoVJOSOMcqt6362KVWt=jZJpembqYPSA@mail.gmail.com>
	<d9cdd707bc83d94a487d39e35c2c8937@scarlet.be>
	<CAG3-T369fdVZm019HXELtzYuxnh_FJSQ4vONkeWZF6UmC-WetQ@mail.gmail.com>
	<3466d1d702525e6b72f3f47216397a35@scarlet.be>
	<CAG3-T34+wRb7xovZRaD68u=fPHWdEga-jsa9v6dkiSEnQNst1g@mail.gmail.com>
	<baec026320723966ba83e60699fdbdc3@scarlet.be>
	<CAG3-T36MqMunE-M_m0jV+hUegaWtSdLoUyE19orf9NfkKYQOtw@mail.gmail.com>
Date: Wed, 1 Jun 2016 11:49:22 +0300
Message-ID: <CAG3-T35M=U1_cLziZnecSCTX8-8Hui1MWmPEWsoW04SzjB8LTw@mail.gmail.com>
Subject: Re: [Math] Adding min/max and argmin/argmax values for an arrays of
 double/int (Comparable).
From: Artem Barger <artem@bargr.net>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=001a114453c2e9ccee05343390c7
archived-at: Wed, 01 Jun 2016 08:49:31 -0000

--001a114453c2e9ccee05343390c7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,


I've create a JIRA ticket MATH-1372 and attached a patch to it, also
submitted PR on GitHub: https://github.com/apache/commons-math/pull/36.

Best regards,
                      Artem Barger.

On Tue, May 31, 2016 at 3:32 AM, Artem Barger <artem@bargr.net> wrote:

>
> On Tue, May 31, 2016 at 3:17 AM, Gilles <gilles@harfang.homelinux.org>
> wrote:
>
>> On Tue, 31 May 2016 02:58:27 +0300, Artem Barger wrote:
>>
>>> Methods "getMinValue()", "getMinIndex()".
>>>>
>>>> Important note: any contribution should be based on the contents of
>>>> the "develop" branch, not "master". See file
>>>>   doc/development/development.howto.txt
>>>> in the source tree.
>>>>
>>>>
>>>> =E2=80=8BSo in order to use them I need to instantiate a RealVector, r=
ight?
>>>
>>
>> Yes.
>> And the iteration is probably not efficient since it use the
>> high-level API.
>>
>> Hence I think the question whenever to add static method w/
>>> similar functionality to MathArrays class is still valid, especially if
>>> I can enhance it to accept array or list of Comparables or to accept
>>> Comparator as an additional parameter=E2=80=8B.
>>>
>>
>> Yes.
>> But perhaps a more general functionality would be useful.
>>
>
> =E2=80=8BGeneral? Could you give an example?
> Aren't these=E2=80=8B enough?
>
> public static <T extends Comparable<T>> T min(T...array);
>
> public static <T extends Comparable<T>> T max(T...array);
>
> public static <T extends Comparable<T>> int argmin(T...array);
>
> public static <T extends Comparable<T>> int argmax(T...array);
>
>
>
>> Especially with the new Java 8 function types.
>>
>
> =E2=80=8BIt's easy to implement having Java 8 function types, not sure I'=
m
> following you
> w/ how it could affect the API's of proposed methods.=E2=80=8B
>
> I think I will submit a JIRA ticket w/ these and submit a patch, reviewin=
g
> it we will
> be able to eventually come to some reasonable solution.
>
> Anyway =E2=80=8Bif such functionality is already exist in "RealVector", I=
 guess
>>>>
>>>>> there is no point of adding
>>>>> it to MathArrays, unless RealVector should be refactored and
>>>>> functionality
>>>>> should be removed from
>>>>> there.
>>>>>
>>>>>
>>>> Yes, refactored it should be:
>>>>  https://issues.apache.org/jira/browse/MATH-765
>>>>
>>>>
>>>> =E2=80=8BIt says that these methods to be removed from RealVector.=E2=
=80=8B
>>>
>>
>> A pity that what it says did not occur. :-}
>>
>
> =E2=80=8B:)))=E2=80=8B
>
> =E2=80=8BBest,
>           Artem Barger.=E2=80=8B
>
>

--001a114453c2e9ccee05343390c7--