Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0572F200AF6 for ; Sat, 11 Jun 2016 11:02:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 03E80160A34; Sat, 11 Jun 2016 09:02:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F15C160A1A for ; Sat, 11 Jun 2016 11:02:26 +0200 (CEST) Received: (qmail 76516 invoked by uid 500); 11 Jun 2016 09:02:25 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 76505 invoked by uid 99); 11 Jun 2016 09:02:25 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2016 09:02:25 +0000 Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id BD7141A0186 for ; Sat, 11 Jun 2016 09:02:24 +0000 (UTC) Received: by mail-wm0-f44.google.com with SMTP id m124so19141440wme.1 for ; Sat, 11 Jun 2016 02:02:24 -0700 (PDT) X-Gm-Message-State: ALyK8tKSPBQ51myvy79fFoATr0oj9RM1K+AVTha3t82tY6d54tKJEIxEIGiVS0g//txOtkQSUmGucGimdAGTBg== X-Received: by 10.194.48.7 with SMTP id h7mr5712566wjn.9.1465635743087; Sat, 11 Jun 2016 02:02:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Benedikt Ritter Date: Sat, 11 Jun 2016 09:02:13 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [bcel] console logging To: Commons Developers List Content-Type: multipart/alternative; boundary=047d7ba975e4d644720534fce9a2 archived-at: Sat, 11 Jun 2016 09:02:27 -0000 --047d7ba975e4d644720534fce9a2 Content-Type: text/plain; charset=UTF-8 No logging via System.out/err. Either use a decent logging framework or use exceptions to propagate errors. I'm in the throw exceptions camp. Benedikt Gary Gregory schrieb am Sa., 11. Juni 2016 um 01:15: > I see this in [bcel]: > > System.out.println(buf.toString()); > e.printStackTrace(); > > Should that be left in there or removed? > > Gary > > -- > E-Mail: garydgregory@gmail.com | ggregory@apache.org > Java Persistence with Hibernate, Second Edition > > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > --047d7ba975e4d644720534fce9a2--