commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niall Pemberton <niall.pember...@gmail.com>
Subject Re: Reformatting commons-io to single code style ?
Date Mon, 27 Jun 2016 20:28:45 GMT
On Mon, Jun 27, 2016 at 1:10 PM, Benedikt Ritter <britter@apache.org> wrote:

> +1 go for it. I'm in the unified code style camp. That's why I reformatted
> the whole code base of BeanUtils2 a while back.
>

+1 from me too.

Niall



>
> Kristian Rosenvold <krosenvold@apache.org> schrieb am Mo., 27. Juni 2016
> um
> 13:21:
>
> > 2016-06-27 12:18 GMT+02:00 sebb <sebbaz@gmail.com>:
> > > This causes lots of grief when trying to track where a particular
> > > section of code was introduced.
> >
> > Tooling has moved on, I'm really not sure this argument is
> > particularly relevant for a git repository.
> > If I want to track provenance I'd use git pickaxe or similar.
> >
> > > Likewise so does reorganising methods alphabetically.
> >
> > My OCD does not cover the order of the methods, this may be because I
> > think most of the applicable standards covering this are just plain
> > dumb.
> >
> > > If the code in a particular source file is really badly mangled then
> > > it's worth standardising it internally, but IMO it's
> > > counter-productive to reformat everything.
> >
> > I would not be writing this email if I thought it was just a minor few
> > hiccups. I think it's possible to define a code style for io that
> > causes a reasonable minimum changeset to the code.
> > As previously mentioned I really dont care about code style - as I've
> > grown older I even stopped rampaging against people that use tabs.
> >
> >
> > So the way I'm reading this I would probably get away by reformatting
> > the worst offenders, especially if I do not do too many files at once
> > (evil grin :)
> >
> > Kristian
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message