commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [2/2] commons-crypto git commit: try-with-resources.
Date Thu, 30 Jun 2016 00:19:00 GMT
On 30 June 2016 at 01:08,  <ggregory@apache.org> wrote:
> try-with-resources.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/b11f6ffa
> Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/b11f6ffa
> Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/b11f6ffa
>
> Branch: refs/heads/master
> Commit: b11f6ffaecef327840c3f42b880937a267ac7637
> Parents: 9ecfae2
> Author: Gary Gregory <ggregory@apache.org>
> Authored: Wed Jun 29 17:08:49 2016 -0700
> Committer: Gary Gregory <ggregory@apache.org>
> Committed: Wed Jun 29 17:08:49 2016 -0700
>
> ----------------------------------------------------------------------
>  .../commons/crypto/cipher/AbstractCipherTest.java   | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/b11f6ffa/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> ----------------------------------------------------------------------
> diff --git a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> index 3da0511..65f1472 100644
> --- a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> +++ b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> @@ -82,18 +82,18 @@ public abstract class AbstractCipherTest {
>
>      @Test
>      public void closeTestAfterInit() throws Exception {
> -        CryptoCipher enc = getCipher(transformations[0]);
> -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.close();
> +        try (CryptoCipher enc = getCipher(transformations[0])) {
> +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +        }

-1

This is specifically designed to test  init and close
It's not helpful to hide the close in the try with resources block.

>      }
>
>      @Test
>      public void reInitTest() throws Exception {
> -        CryptoCipher enc = getCipher(transformations[0]);
> -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.close();
> +        try (CryptoCipher enc = getCipher(transformations[0])) {
> +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +            enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +        }

-1

DItto

>      }
>
>      @Test
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message