commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [bcel] Deprecated InstructionConstants
Date Wed, 01 Jun 2016 06:54:33 GMT
On Tue, May 31, 2016 at 11:36 PM, Jan Matèrne (jhm) <apache@materne.de>
wrote:

> > The interface org.apache.commons.bcel6.generic.InstructionConstants is
> > deprecated in favor of a class. It seems OK to delete it since bcel6 is
> > a major new release.
> >
> > Check?
>
> Had a look at the source and history:
>
> Source [1]:
> @deprecated (since 6.0) Do not use. Use InstructionConst instead.
> ==> When deprecating with 6.0, deleting it in 6.0 as well would be too
> early in my opinion.
>

It does not make sense though. All of the code in the bcel6 package is
going to be released for the first time in the upcoming 6.0 release.

No one can have written code against these deprecated classes. What am I
missing. That these classes existed in version 5.x in a different package?
So what, a new version is the opportunity to drop old code. Other wise we
are adding new code, deprecating it right away, without an opportunity to
remove it until the _next_ major release, 7.0.

Gary


>
> History [2]:
> Javac-@Deprecated added in Sep 2015 [3]
> Javadoc-@Deprecatad is older. Havent found the initial commit.
>
>
> As I am not familiar with BCEL source, are you sure its deprecated long
> enough?
>
>
> Jan
>
>
> [1]
> https://github.com/apache/commons-bcel/blob/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConstants.java
> [2]
> https://github.com/apache/commons-bcel/blame/trunk/src/main/java/org/apache/commons/bcel6/generic/InstructionConstants.java
> [3]
> https://github.com/apache/commons-bcel/commit/885b0a0a353275739c9b1658a8384fdbf6a9af2b
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message