commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Apache Commons BeanUtils 1.9.3 RC1
Date Mon, 06 Jun 2016 21:28:49 GMT
On Mon, Jun 6, 2016 at 7:51 AM, Stian Soiland-Reyes <stain@apache.org>
wrote:

> Thanks for putting this RC together, Gary, a BeanUtils release is most
> welcome.
>
> Unfortunately, my vote: -1 (binding)
>
> .. because the build fails in Windows.
>
> Checked:
>
> +1 signatures
> +1 sha1 hashes
> +1 LICENSE, NOTICE
> +1 RELEASE-NOTES.txt
> -1 no README
>

Thank you for your review Stian :-)

Not a blocker IMO but I added a README.md to trunk as generated by 'mvn
commons:readme-md'.


> +1 mvn apache-rat check
> -1 What is the file build.properties.sample needed for? Do we still do
> Ant? This needs to be documented in a README.
>

Yep, we still have Ant builds laying around a lot of Commons component. I
do not see why this is a blocker though. I am happy to remove all Ant files
if that is the consensus.


> -1 mvn clean install fails
>

This is no different than version 1.9.2 with Java 8.

Failed tests:
  org.apache.commons.beanutils.bugs.Jira422TestCase#testRootBean
ComparisonFailure
  org.apache.commons.beanutils.bugs.Jira422TestCase#testSecondChildBean
ComparisonFailure
  org.apache.commons.beanutils.IndexedPropertyTestCase#testSetListItemA
AssertionFailedError

org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedPropertyDescriptor
AssertionFailedError

org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListIndexedPropertyDescriptor
AssertionFailedError
  org.apache.commons.beanutils.IndexedPropertyTestCase#testListReadMethod
AssertionFailedError
  org.apache.commons.beanutils.IndexedPropertyTestCase#testListWriteMethod
AssertionFailedError

org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedReadMethod
AssertionFailedError

org.apache.commons.beanutils.IndexedPropertyTestCase#testListIndexedWriteMethod
AssertionFailedError

org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListReadMethod
AssertionFailedError

org.apache.commons.beanutils.IndexedPropertyTestCase#testArrayListWriteMethod
AssertionFailedError

Tests run: 1276, Failures: 11, Errors: 0, Skipped: 0

I had not thought to support Java 8 in this maintenance release. I happy do
to so if someone puts forth a patch. Otherwise, this could be more of a
1.10 theme.

Thoughts?

Gary


>
>
> Failed tests:
>   IndexedPropertyTestCase.testArrayListIndexedPropertyDescriptor:175
> Not IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
>   IndexedPropertyTestCase.testArrayListReadMethod:316 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
>   IndexedPropertyTestCase.testArrayListWriteMethod:330 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
>   IndexedPropertyTestCase.testListIndexedPropertyDescriptor:156 Not
> IndexedPropertyDescriptor expected:<class
> java.beans.IndexedPropertyDescriptor> but was:<class
> java.beans.PropertyDescriptor>
>   IndexedPropertyTestCase.testListIndexedReadMethod:288 Threw
> exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> cannot be cast to java.beans.IndexedPropertyDescriptor
>   IndexedPropertyTestCase.testListIndexedWriteMethod:302 Threw
> exception java.lang.ClassCastException: java.beans.PropertyDescriptor
> cannot be cast to java.beans.IndexedPropertyDescriptor
>   IndexedPropertyTestCase.testListReadMethod:256 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
>   IndexedPropertyTestCase.testListWriteMethod:274 Threw exception
> java.lang.ClassCastException: java.beans.PropertyDescriptor cannot be
> cast to java.beans.IndexedPropertyDescriptor
>   Jira422TestCase.testRootBean:36 expected:<java.[lang.String]> but
> was:<java.[util.List]>
>   Jira422TestCase.testSecondChildBean:42 expected:<java.[lang.String]>
> but was:<java.[util.List]>
>
>
> Second build gives same error.
>
>
>
> Tested with:
>
> C:\Users\stain>mvn -v
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T16:41:47+00:00)
> Maven home: C:\Program Files\apache-maven-3.3.9\bin\..
> Java version: 1.8.0_92, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_92\jre
> Default locale: en_GB, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"
>
> This is Windows 10 Pro Insider Preview 14332.rs1_release.160422-1940 -
> but I can't see how that could affect the class casting..
>
>
> I see BeanUtils is not listed on
> https://builds.apache.org/view/Apache%20Commons/ so I'll add it there.
>
> On 3 June 2016 at 01:24, Gary Gregory <garydgregory@gmail.com> wrote:
> > Apache Commons BeanUtils 1.9.3 RC1 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/beanutils/
> > (revision 13874)
> >
> > commons-beanutils-1.9.3-bin.tar.gz
> > (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709)
> > commons-beanutils-1.9.3-bin.zip
> > (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3)
> > commons-beanutils-1.9.3-src.tar.gz
> > (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06)
> > commons-beanutils-1.9.3-src.zip
> > (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313)
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/
> >
> > These are the artifacts and their hashes:
> >
> > commons-beanutils-1.9.3-test-sources.jar
> > (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f)
> > commons-beanutils-1.9.3-sources.jar
> > (SHA1: 53bae8809672897cb9954669775fb214623c6b89)
> > commons-beanutils-1.9.3.pom
> > (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55)
> > commons-beanutils-1.9.3.jar
> > (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c)
> > commons-beanutils-1.9.3-javadoc.jar
> > (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf)
> > commons-beanutils-1.9.3-tests.jar
> > (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b)
> >
> > Details of changes since 1.9.2 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html
> >
> >
> > The tag is here:
> >
> https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/
> > (revision 1745420)
> >
> > Site:
> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/
> >
> > (some *relative* links are broken - these will be OK once the site
> > is deployed)
> >
> > Clirr Report (compared to 1.9.2):
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html
> >
> > RAT Report:
> >
> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> >
> > This vote will close no sooner than 72 hours from now, i.e. sometime
> after
> > 18:00 PST 5 June 2016
> >
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Gary Gregory
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message