commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sun, Dapeng" <dapeng....@intel.com>
Subject RE: [crypto] Instructions MUST mention running the tests
Date Tue, 07 Jun 2016 03:42:25 GMT
Thank Bernd, it seems "mvn verify" can't cover creating binary distribution, I think we can
add it to Jenkins.

Regards
Dapeng

-----Original Message-----
From: ecki@zusammenkunft.net [mailto:ecki@zusammenkunft.net] 
Sent: Tuesday, June 07, 2016 10:40 AM
To: Commons Developers List
Subject: Re: [crypto] Instructions MUST mention running the tests

Hello,

I also make a habit out of using "mvn verify" instead of "mvn package" (for the same reason,
do never document circumventing potential tests).

Gruss
Bernd

--
http://bernd.eckenfels.net

-----Original Message-----
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Sent: Di., 07 Juni 2016 4:37
Subject: [crypto] Instructions MUST mention running the tests

Hi All:

When I see instructions in BUILDING.txt like:

Create binary distribution:

  $ mvn package -DskipTests

I am worried!

Why would you NOT want to run unit tests? Skipping tests from Maven is a hack when you know
what you are doing. Like when I just ran the tests, all passed, and I changed something that
is not Java source.

IMO, we need better build instructions.

I've added steps for RAT and Clirr, a must for any Maven component here.

Thank you,
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second
Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Mime
View raw message