commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1742539 - /commons/proper/io/trunk/pom.xml
Date Mon, 09 May 2016 11:02:27 GMT
On 9 May 2016 at 11:55, Benson Margulies <bimargulies@gmail.com> wrote:
> You need to checkout the tag, run a build, and then try to run the
> site build. Be careful that you don't overwrite the live site.
>
> The pattern at the Maven PMC is to set the distro management URL to
> some location safely NOT the live site, and then use svn cp as part of
> the release process to put the content into place, FWIW.

I agree that's safer, but it might not work with Commons.
The pom expects to be able to download the existing site.
Unless the download and upload use different variables, changing one
will obviously affect the other.
Maybe the whole approach needs revising; I'll start a new thread.

>
> On Mon, May 9, 2016 at 6:28 AM, sebb <sebbaz@gmail.com> wrote:
>> On 9 May 2016 at 10:56, sebb <sebbaz@gmail.com> wrote:
>>> On 9 May 2016 at 08:15, Benedikt Ritter <britter@apache.org> wrote:
>>>> Hi,
>>>>
>>>> Benson Margulies <bimargulies@gmail.com> schrieb am So., 8. Mai 2016
um
>>>> 15:11 Uhr:
>>>>
>>>>> As far as I could see, mvn site-deploy is running the
>>>>> maven-scm-publish-plugin, that is using that URL from
>>>>> distribution-management. maybe someone configured it wrong. I'm happy
>>>>> to pass the whole issue off to you.
>>>>>
>>>>
>>>> I've tried building the site from trunk, but I got:
>>>>
>>>> [ERROR] Failed to execute goal
>>>> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on
>>>> project commons-io: Execution default-site of goal
>>>> org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
>>>> NullPointerException -> [Help 1]
>>>> [ERROR]
>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with the
-e
>>>> switch.
>>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>>> [ERROR]
>>>> [ERROR] For more information about the errors and possible solutions,
>>>> please read the following articles:
>>>> [ERROR] [Help 1]
>>>> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
>>>>
>>>> Any idea?
>>>
>>> How does the IO pom differ from other Commons projects that don't have
>>> this issue?
>>
>> Actually that won't help.
>> However using -e as suggested by Maven shows:
>>
>> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
>> default-site of goal
>> org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
>>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>>     ... 20 more
>> Caused by: java.lang.NullPointerException
>>     at org.codehaus.mojo.clirr.ClirrReportGenerator$ApiChangeComparator.compare(ClirrReportGenerator.java:64)
>>     at org.codehaus.mojo.clirr.ClirrReportGenerator$ApiChangeComparator.compare(ClirrReportGenerator.java:57)
>>
>> So there's a bug in the Clirr plugin.
>>
>> -Dclirr.skip=true should in theory skip the report, however that does not work.
>> My guess is that it would not run that code if report generation were
>> skipped, thus avoiding the NPE.
>>
>> One can use -Dcommons.clirr.version=2.6 to downgrade the Clirr
>> version; that fixes the issue for me.
>> The version can be overridden in the pom properties for now in any
>> projects that trigger the issue.
>> NET also uses CP40 but does not cause the NPE.
>>
>> Note: to speed up such testing, the -Psite-quick profile is useful
>> (although in theory it will not run Clirr!)
>>
>> I will try reporting the bugs against the plugin
>>
>>>> Benedikt
>>>>
>>>>
>>>>>
>>>>> On Sun, May 8, 2016 at 8:13 AM, Benedikt Ritter <britter@apache.org>
>>>>> wrote:
>>>>> > Hi Benson,
>>>>> >
>>>>> > Benson Margulies <bimargulies@gmail.com> schrieb am So., 8.
Mai 2016 um
>>>>> > 14:05 Uhr:
>>>>> >
>>>>> >> When I arrived as the RM, I found a URL in there that ended
with
>>>>> >> 'commons-i'.
>>>>> >>
>>>>> >> So, when I did the release, I patched it to end with 'commons-io'
>>>>> >> before running the site-deploy that runs the maven-scm-publish-plugin.
>>>>> >>
>>>>> >> The result was javadoc at the root of the site, instead of down
where
>>>>> >> it belongs.
>>>>> >>
>>>>> >> So, I hypothesized that I needed to make the change that is
under
>>>>> >> discussion here. If it's the wrong change, someone please replace
it
>>>>> >> with the right change.
>>>>> >>
>>>>> >
>>>>> > your first patch was correct. The URL should end with commons-io.
Have a
>>>>> > look at the site directory of commons lang [1]. The apidocs directory
>>>>> > contains the current JavaDocs. It is deployed by mvn site-deploy.
In
>>>>> > addition to that, we manually add release JavaDocs to the javadoc
>>>>> > directory. It serves as an archive.
>>>>> >
>>>>> > For whatever reason, the apidocs directory is missing in the commons-io
>>>>> > site directory. I'll try to have a look later today or tomorrow
morning.
>>>>> >
>>>>> > BR,
>>>>> > Benedikt
>>>>> >
>>>>> > [1]
>>>>> >
>>>>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang/
>>>>> >
>>>>> >
>>>>> >>
>>>>> >>
>>>>> >> On Sun, May 8, 2016 at 7:44 AM, Benedikt Ritter <britter@apache.org>
>>>>> >> wrote:
>>>>> >> > sebb <sebbaz@gmail.com> schrieb am So., 8. Mai 2016
um 13:17 Uhr:
>>>>> >> >
>>>>> >> >> On 6 May 2016 at 13:31,  <bimargulies@apache.org>
wrote:
>>>>> >> >> > Author: bimargulies
>>>>> >> >> > Date: Fri May  6 12:31:46 2016
>>>>> >> >> > New Revision: 1742539
>>>>> >> >> >
>>>>> >> >> > URL: http://svn.apache.org/viewvc?rev=1742539&view=rev
>>>>> >> >> > Log:
>>>>> >> >> > Fix the javadoc publication URL.
>>>>> >> >>
>>>>> >> >> -1
>>>>> >> >>
>>>>> >> >> That is not only used for Javadoc.
>>>>> >> >> It is used for the entire site.
>>>>> >> >>
>>>>> >> >
>>>>> >> > Yes, it is interpreted by mvn site-deploy. What exactly
where you
>>>>> trying
>>>>> >> to
>>>>> >> > fix? I'm sure we can find another way to fix this.
>>>>> >> >
>>>>> >> > Benedikt
>>>>> >> >
>>>>> >> >
>>>>> >> >>
>>>>> >> >> > Modified:
>>>>> >> >> >     commons/proper/io/trunk/pom.xml
>>>>> >> >> >
>>>>> >> >> > Modified: commons/proper/io/trunk/pom.xml
>>>>> >> >> > URL:
>>>>> >> >>
>>>>> >>
>>>>> http://svn.apache.org/viewvc/commons/proper/io/trunk/pom.xml?rev=1742539&r1=1742538&r2=1742539&view=diff
>>>>> >> >> >
>>>>> >> >>
>>>>> >>
>>>>> ==============================================================================
>>>>> >> >> > --- commons/proper/io/trunk/pom.xml (original)
>>>>> >> >> > +++ commons/proper/io/trunk/pom.xml Fri May  6
12:31:46 2016
>>>>> >> >> > @@ -44,7 +44,7 @@ file comparators, endian transformation
>>>>> >> >> >      <site>
>>>>> >> >> >        <id>apache.website</id>
>>>>> >> >> >        <name>Apache Commons Site</name>
>>>>> >> >> > -      <url>scm:svn:
>>>>> >> >>
>>>>> >>
>>>>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-io/
>>>>> >> >> </url>
>>>>> >> >> > +      <url>scm:svn:
>>>>> >> >>
>>>>> >>
>>>>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-io/javadocs/api-${project.version}
>>>>> >> >> </url>
>>>>> >> >> >      </site>
>>>>> >> >> >    </distributionManagement>
>>>>> >> >> >
>>>>> >> >> >
>>>>> >> >> >
>>>>> >> >>
>>>>> >> >> ---------------------------------------------------------------------
>>>>> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> >> >> For additional commands, e-mail: dev-help@commons.apache.org
>>>>> >> >>
>>>>> >> >>
>>>>> >>
>>>>> >> ---------------------------------------------------------------------
>>>>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> >> For additional commands, e-mail: dev-help@commons.apache.org
>>>>> >>
>>>>> >>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message