Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: 
 <CAOGo0VZOoXQLtXG6+0hPrTHieVTaZNSZvP6RR6DuwbSkeQK0og@mail.gmail.com>
References: 
 <CAOGo0VaVa1++7Um4fHk_H9pr_a2pNT6=Z1BLQ3OkDdZ=_ChOBw@mail.gmail.com>
	<CAMBJEmXr_wWn5yhay6uZgh_-=p=Ze1sFdfZetP3QYj2TL0r35w@mail.gmail.com>
	<CAOGo0VZOoXQLtXG6+0hPrTHieVTaZNSZvP6RR6DuwbSkeQK0og@mail.gmail.com>
Date: Sat, 16 Apr 2016 18:04:51 +0100
Message-ID: 
 <CAOGo0VY0gSwQs6AngxjeGjNrYqDawdooA3qb2KvdjtdcctGaDw@mail.gmail.com>
Subject: Re: [VOTE] Commons-net 3.5 based on RC1
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8

On 16 April 2016 at 17:13, sebb <sebbaz@gmail.com> wrote:
> On 16 April 2016 at 13:12, Stian Soiland-Reyes <stain@apache.org> wrote:
>>  My vote: +1 (non-binding)
>>
>> 0 No README.txt or BUILD.txt - how do I build it? I'll assume "mvn
>> clean install" with Maven 3.0.1 as specified in parent pom
>
> That applies to most Commons components...
>
>> +1 checksums/signatures
>> +1 zip vs tar.gz
>> +1 src vs svn rev vs svn tag
>> +1 mvn clean verify
>> 0 target/ match binaries (but src builds also the subset
>> commons-net-ftp-3.5.jar which is missing from binaries/ - what is
>> this?)
>> +1 No api changes since 3.4 (beyond requirement of Java 1.6)
>> +1 release notes / JIRA  (but why is "Alternative password input
>> methods for IMAP examples" not in Jira?)
>> +1 mvn apache-rat:check
>> ? mvn site
>> +1 binary jar's .class files are 1.6 compatible
>> +1 mvn repository commons-net-3.5.jar match jar in binaries/
>> +1 commons-net-3.5-sources.jar match source src/main/java/
>>
>>
>>
>> The previous 3.4 binary release
>> https://dist.apache.org/repos/dist/release/commons/net/binaries/commons-net-3.4-bin.zip
>> also included these jars:
>> commons-net-3.4-sources.jar  commons-net-examples-3.4.jar
>>
>> But 3.5 only includes:
>> commons-net-3.5.jar
>>
>>
>> Should the fact that these are missing in 3.5 be mentioned?
>> (examples are still included under examples/)
>
> Not sure why that is missing. It was not an intentional change.

Maven seems to create the bin archive before it creates the additional jars.
Unfortunately Maven ignores missing references in assembly descriptors
- not even a warning.

Looks like it is necessary to use the 'package' goal as well.
That seems to re-create the bin/src archives again later, by which
time the additional jars have been created.


> It's not critical, but it would be better if it were included.
> Let's see if anything else turns up.
>
>>
>>
>> build tested with:
>>
>> Ubuntu 14.04 / Open JDK 8:
>>
>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> 2015-11-10T16:41:47+00:00)
>> Maven home: /home/stain/software/maven
>> Java version: 1.8.0_72-internal, vendor: Oracle Corporation
>> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "3.16.0-67-generic", arch: "amd64", family: "unix"
>>
>>
>> Docker image maven  (a42124be49e0)
>>
>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> 2015-11-10T16:41:47+00:00)
>> Maven home: /usr/share/maven
>> Java version: 1.8.0_72-internal, vendor: Oracle Corporation
>> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
>> Default locale: en, platform encoding: UTF-8
>> OS name: "linux", version: "3.16.0-67-generic", arch: "amd64", family: "unix"
>>
>>
>> Docker image java:6 (c303b30f54b5) (old skool with mvn 3.0.3)
>>
>> Apache Maven 3.0.3 (r1075438; 2011-02-28 17:31:09+0000)
>> Maven home: /tmp/apache-maven-3.0.3
>> Java version: 1.6.0_38, vendor: Sun Microsystems Inc.
>> Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
>> Default locale: en, platform encoding: UTF-8
>> OS name: "linux", version: "3.16.0-67-generic", arch: "amd64", family: "unix"
>>
>>
>>
>> On 15 April 2016 at 23:42, sebb <sebbaz@gmail.com> wrote:
>>> It's about time to release the next version of NET.
>>>
>>> ==
>>>
>>> NET 3.5 RC1 is available for review here:
>>>     https://dist.apache.org/repos/dist/dev/commons/net/
>>>     (revision 13271)
>>>
>>> binaries/commons-net-3.5-bin.tar.gz.sha1:798851e256b64d6d03739bc24418369de3f9da7d
>>> binaries/commons-net-3.5-bin.zip.sha1:2418808e04005aa706de8e62e5592d32be1f34fc
>>> source/commons-net-3.5-src.tar.gz.sha1:8ccedbbf247ad916f0e2f0d57b8a68c7784db1bb
>>> source/commons-net-3.5-src.zip.sha1:f72bd8b5bf734930107b185588c6fe695513c270
>>>
>>>   Maven artifacts are here:
>>>     https://repository.apache.org/content/repositories/orgapachecommons-1149/commons-net/commons-net/3.5/
>>>
>>> These are the artifacts and their hashes
>>>
>>> /commons-net/commons-net/3.5/commons-net-3.5-test-sources.jar
>>> (SHA1: be2a7e5b07fb693ce02e0b1982d31484b9974670)
>>> /commons-net/commons-net/3.5/commons-net-3.5-sources.jar
>>> (SHA1: 1f3a44fe2766e3fb333150235c108bbf21f56163)
>>> /commons-net/commons-net/3.5/commons-net-3.5-ftp.jar
>>> (SHA1: e32bf348565421a1c55625e5830737f4019dbe52)
>>> /commons-net/commons-net/3.5/commons-net-3.5.jar
>>> (SHA1: f497c63d2be3180a54122245938230ca9e3bb5a2)
>>> /commons-net/commons-net/3.5/commons-net-3.5-examples.jar
>>> (SHA1: a719e650f46c499551752c458ef1bcf9ed4ef940)
>>> /commons-net/commons-net/3.5/commons-net-3.5-tests.jar
>>> (SHA1: ba42d4ef89e8c940f111218c77875299faef22b4)
>>> /commons-net/commons-net/3.5/commons-net-3.5.pom
>>> (SHA1: 284b24dfd9cc4f0bf23c8d2ff4d95bc70fb374dc)
>>> /commons-net/commons-net/3.5/commons-net-3.5-javadoc.jar
>>> (SHA1: d858126e2260adf6e8ed2b84e12acabb7fce17ad)
>>>
>>>   Details of changes since 3.4 are in the release notes:
>>>     https://dist.apache.org/repos/dist/dev/commons/net/RELEASE-NOTES.txt
>>>     http://home.apache.org/~sebb/net-3.5-RC1/changes-report.html
>>>
>>>   I have tested this with JDK 1.6, 1.7, 1.8 using Apache Maven 3.3.3
>>>
>>>   The tag is here:
>>>     http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_5_RC1/
>>>     (revision 1739355)
>>>
>>>   Site:
>>>     http://home.apache.org/~sebb/net-3.5-RC1/
>>>    (some *relative* links are broken - these will be OK once the site
>>> is deployed)
>>>
>>>   Clirr Report (compared to 3.4):
>>>     http://home.apache.org/~sebb/net-3.5-RC1/clirr-report.html
>>>
>>>   RAT Report:
>>>     http://home.apache.org/~sebb/net-3.5-RC1/rat-report.html
>>>
>>>   KEYS:
>>>   https://www.apache.org/dist/commons/KEYS
>>>
>>>   Please review the release candidate and vote.
>>>   This vote will close no sooner than 72 hours from now,
>>>   i.e. sometime after 23:00 GMT 18 Apr 2016
>>>
>>>
>>>   [ ] +1 Release these artifacts
>>>   [ ] +0 OK, but...
>>>   [ ] -0 OK, but really should fix...
>>>   [ ] -1 I oppose this release because...
>>>
>>>   Thanks!
>>>
>>>   Sebb
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>>
>> --
>> Stian Soiland-Reyes
>> Apache Taverna (incubating), Apache Commons RDF (incubating)
>> http://orcid.org/0000-0001-9842-9718
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org