Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5695B19F17 for ; Fri, 15 Apr 2016 15:33:08 +0000 (UTC) Received: (qmail 76439 invoked by uid 500); 15 Apr 2016 15:33:03 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 76291 invoked by uid 500); 15 Apr 2016 15:33:02 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 76279 invoked by uid 99); 15 Apr 2016 15:33:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 15:33:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 00B39180579 for ; Fri, 15 Apr 2016 15:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.021 X-Spam-Level: X-Spam-Status: No, score=-0.021 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GZVRMyH6bm1W for ; Fri, 15 Apr 2016 15:33:00 +0000 (UTC) Received: from mail-ig0-f180.google.com (mail-ig0-f180.google.com [209.85.213.180]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E656C5F23C for ; Fri, 15 Apr 2016 15:32:59 +0000 (UTC) Received: by mail-ig0-f180.google.com with SMTP id ui10so25791497igc.1 for ; Fri, 15 Apr 2016 08:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=AGWC9Ublbpxu+RlXXbmz44Ox/vZ0shmaldGPS4NeKfE=; b=GrtAUahSm6JaYw5i2LoG+/XJZKkTIhrOPbziwx1GWuVEjjco3LVEhjRqT7GsoupoLq Yg20V2RMP/DpxNABqx1c1QzOz5H6ZlMSraXvVIzyPVE1zStkEFdm7ZvrfkDe5K47Y+3l O51qXV/e9YS/IH228aidtKVNrdnLmjW9eaPQp8RIzucK0TROBDy7X3P6Ukp7wDjpbXSj k04EYwVLRKZAymWKMJdO1xYK4dH2e+HR/5C62y6usG9g4z+eeQJfkWGoP/t7T4POYLJg duJ1UUz0/0IFtBgmW8+pMJXz2ImMa2jV8NKnflEirPk1bjjm0+qN+GpYtQu4nld0oiuI lBxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=AGWC9Ublbpxu+RlXXbmz44Ox/vZ0shmaldGPS4NeKfE=; b=HIW/6+OLITLQZbODKO7LPTbRuzmvRW1reM6Zde8qpTbBMUi7Uh+VJ9e3AA07McE/Uv RgOWAd+nmJCydis5R5lMzrH11hTeeP9bcCyW9LMx2/S/bwXCl1gasfW4sakem2dhCbl3 NZUVfNxBwUd8zlit9WCS+lMURK9OZjertNb+HBtU6kyAiqkFdD7ndEDMcWx2UamJDedE YdVdYUNvGex4U5F00HpFSDQuKErz9EG8wvo+gg/CVz3ZOfdrq0JLSMAM18D8PleLHDKh EAUEE6OQFfeMKklC1OotZjGfPAHVtWuLV4LKnM+mn2SQaUavysRTxJkkiMOwlbmBG5km 2hUg== X-Gm-Message-State: AOPr4FXljStpzBHlCfANbon29cbbCB0ZHs78Nmd6eTwPdKBGBuS3mHyZSgGoqJIwgzn68GQihNOOrFU9FZjmoA== MIME-Version: 1.0 X-Received: by 10.50.57.79 with SMTP id g15mr6084675igq.54.1460734378825; Fri, 15 Apr 2016 08:32:58 -0700 (PDT) Received: by 10.50.151.168 with HTTP; Fri, 15 Apr 2016 08:32:58 -0700 (PDT) In-Reply-To: References: Date: Fri, 15 Apr 2016 11:32:58 -0400 Message-ID: Subject: Re: Is there an missing bit in the instructions for making a release? From: Benson Margulies To: Commons Developers List Content-Type: text/plain; charset=UTF-8 On Fri, Apr 15, 2016 at 11:29 AM, sebb wrote: > Thanks! > > It also occurs to me that having the RC tag in the POM is not > necessarily a problem. If you prefer to modify the doc to tell people how to use the plugin so that the net result is the RC tag in the POM, OK. That satisfies my ask for a set of instructions that an RM can follow without getting into a controversy. All this will be moot if some other voters don't show up. > > So long as the tag is retained after a successful vote, then does it > matter whether the tag in the POM is IO-1.2.3-RC4 or IO-1.2.3 ? > > On 15 April 2016 at 16:02, Brent Worden wrote: >> I probably won't be much help either as I have never used the plugin but, >> there is a tag option for the plugin that might help control the SCM tag >> that is used. Of all the options for the plugin listed on >> https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html, >> the tag* options might meet your needs. >> >> >> Thanks, >> >> Brent >> >> On Fri, Apr 15, 2016 at 5:16 AM, Benson Margulies >> wrote: >> >>> On Thu, Apr 14, 2016 at 10:33 PM, sebb wrote: >>> > On 15 April 2016 at 02:19, Benson Margulies >>> wrote: >>> >> Sebb, >>> >> >>> >> I don't know why you think I could distinguish the following possible >>> >> behaviors of prior RMs with a reasonable level of effort: >>> > >>> > As I have already said, I don't use the plugin. >>> > However I have followed release votes and AFAICR the final tag never >>> > been created before the vote completed. >>> > In all cases I can remember, the final tag is created once the vote >>> > has completed. >>> > And I am pretty certain other RMs have used the release plugin. >>> > >>> > So it seems clear to me that something has gone wrong here. >>> > >>> > I don't know what, so I think we need input from an RM who has used >>> > the release plugin. >>> > They should be able to point out what is missing from the instructions. >>> >>> This started when I sent email two days ago saying that I was >>> perplexed by the instructions. I only proceeded when no prior RM, or >>> anyone else, answered. >>> >>> Maybe they used -DdryRun=true and then edited. Maybe I'm just being >>> obtuse. We'll see. >>> >>> >>> >>> > >>> >> 1: didn't use the maven-release-plugin >>> >> 2: did use the maven-release-plugin and then used svn mvn to rename >>> >> the tag it created >>> >> 3: did use the maven-release-plugin, typed 'commons-io-2.x-RCy' at the >>> >> prompt, and released with a pom with an incorrect scm element. >>> >> 4: something else I didn't think of. >>> >> >>> >> I didn't volunteer to be an archaeologist, I volunteered to be a >>> >> release manager.. >>> >> >>> >> At best, the doc is, as I wrote to start this conversation, >>> >> incomplete, in that it does not give specific instructions for >>> >> achieving the PMC's goals using the plugin. >>> >> >>> >> To me, the following sequence is inoffensive: >>> >> >>> >> 1: run release:prepare, creating a premature 'real' tag. >>> >> 2: svn mv to convert that tag to an -RC tag. >>> >> 3: svn mv again to convert it to a (conventionally) immutable 'real >>> >> tag' if the vote passes. >>> >> >>> >> However, what I find inoffensive isn't important here. I'm not a PMC >>> >> member here. If this PMC has a strong policy of tag immutability, then >>> >> this PMC needs to document a procedure that both treats tags as >>> >> immutable and creates completely correct poms, including the scm >>> >> element that has to anticipate the eventual tag. It could create that >>> >> policy by erasing any mention of release:prepare, or by filling in the >>> >> missing details (though I continue to believe that there is no way to >>> >> make it come out the way you want.) >>> >> >>> >> Believe me, if I ever RM another commons release, I won't use >>> >> release:prepare until and unless someone writes up a step-by-step >>> >> guide that leads me to do so in an acceptable way. >>> >> >>> >> If you examine the 'tags' directory in svn right now, you will see >>> >> that it contains what I believe that you want it to contain: no >>> >> commons-io-2.5 tag, but rather a commons-io-2.5-RC4 tag. So, I >>> >> respectfully submit that we could proceed to decide if this release is >>> >> good enough, and sort out the documentation later. >>> >> >>> >> --------------------------------------------------------------------- >>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> >> For additional commands, e-mail: dev-help@commons.apache.org >>> >> >>> > >>> > --------------------------------------------------------------------- >>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> > For additional commands, e-mail: dev-help@commons.apache.org >>> > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> For additional commands, e-mail: dev-help@commons.apache.org >>> >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org