commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles <gil...@harfang.homelinux.org>
Subject [Math] Log messages (Was: [1/4] [math] Adding test [...])
Date Sat, 30 Apr 2016 10:40:50 GMT
Hi Rob.

On Sat, 30 Apr 2016 10:14:19 -0000, erans@apache.org wrote:
> Repository: commons-math
> Updated Branches:
>   refs/heads/develop 0ff84e6a5 -> 3ec3a2e35
>
>
> Adding test coverage for math4.analysis.funtiona and euclidean.twod

Thanks for your contribution.

Just a couple of nit-picking remarks:
  * The log should contain the corresponding JIRA issue id, when there 
is one.
  * When referring to a package name, it's clearer to have it in full, 
and
    abbreviate the top-level components: i.e.
      o.a.c.m.geometry.euclidean.twod

Best regards,
Gilles

>
> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
> Commit: 
> http://git-wip-us.apache.org/repos/asf/commons-math/commit/37c4939a
> Tree: 
> http://git-wip-us.apache.org/repos/asf/commons-math/tree/37c4939a
> Diff: 
> http://git-wip-us.apache.org/repos/asf/commons-math/diff/37c4939a
>
> Branch: refs/heads/develop
> Commit: 37c4939a8a027eefb3673b49301814d086f2eef1
> Parents: f16d5b1
> Author: Rob Tompkins <chtompki@gmail.com>
> Authored: Sat Apr 9 21:17:51 2016 -0400
> Committer: Rob Tompkins <chtompki@gmail.com>
> Committed: Sat Apr 23 08:29:35 2016 -0400
>
> 
> ----------------------------------------------------------------------
>  pom.xml                                         |   3 +
>  .../function/BivariateFunctionTest.java         |  44 ++++
>  .../UnivariateDifferentiableFunctionTest.java   | 229 
> +++++++++++++++++++
>  .../function/UnivariateFunctionTest.java        | 124 ++++++++++
>  .../euclidean/twod/NestedLoopsTest.java         |  67 ++++++
>  .../geometry/euclidean/twod/Vector2DTest.java   | 210 
> ++++++++++++++++-
>  6 files changed, 671 insertions(+), 6 deletions(-)
> 
> ----------------------------------------------------------------------
>
> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message