commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/ main/java/org/apache/commons/dbcp2/managed/ test/java/or...
Date Mon, 08 Feb 2016 22:51:48 GMT
On Feb 8, 2016 2:08 PM, "Emmanuel Bourg" <ebourg@apache.org> wrote:
>
> Le 8/02/2016 22:56, ggregory@apache.org a écrit :
> > Modified:
commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java
> > URL:
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java?rev=1729274&r1=1729273&r2=1729274&view=diff
> >
==============================================================================
> > ---
commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java
(original)
> > +++
commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java
Mon Feb  8 21:56:48 2016
> > @@ -82,7 +82,7 @@ public class DelegatingPreparedStatement
> >          try {
> >              return
DelegatingResultSet.wrapResultSet(this,((PreparedStatement)getDelegate()).executeQuery());
> >          }
> > -        catch (SQLException e) {
> > +        catch (final SQLException e) {
> >              handleException(e);
> >              throw new AssertionError();
> >          }
>
> Am I the only one to think this syntax is uselessly verbose ? I'm ok
> with final class variables, less with final local parameters, but final
> exceptions look really useless to me.

It's simpler to be consistent when using final IMO. The intent is the same:
https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/

Gary
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message