Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B169218DDE for ; Sat, 2 Jan 2016 18:23:44 +0000 (UTC) Received: (qmail 3291 invoked by uid 500); 2 Jan 2016 18:23:44 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 3138 invoked by uid 500); 2 Jan 2016 18:23:44 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 3126 invoked by uid 99); 2 Jan 2016 18:23:44 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jan 2016 18:23:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 91E7C1804B4 for ; Sat, 2 Jan 2016 18:23:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Sz1KWi7tl4Kp for ; Sat, 2 Jan 2016 18:23:36 +0000 (UTC) Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 0BE8F258DB for ; Sat, 2 Jan 2016 18:23:35 +0000 (UTC) Received: by mail-pa0-f50.google.com with SMTP id yy13so83640270pab.3 for ; Sat, 02 Jan 2016 10:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=pkm13oBjNozAAzh85cAOMjw9CktJPi0MagyN9kB47tU=; b=kz0jutEQr++w081QECDNAaxMxjDZhk3PMTACgQwe9WAIrZIYM4mM4KL8ZM+sygTCvJ SEoB8hvTMgq3Q85qxrZoWzzDiHTUlnTqO3nAee3Kl+UU3I3q4RncZqURsiwuGzXQZ1Sl 5NOnM4ZM1NrR2vCzLl64z8QMBC2PBtHKfGXjDS/dwDXHHs0OaNBE236ksqAJ8I3C192x CJQwL6moh2mG9nsYfj73uCc5SVeBkkhYzSmPjSM9QUboDTAwrGp8OM3zpcPFaU1kzZx6 5Lb39Sl0zRj8lD04EbSJ020HRex0fYhNLbJt3znuYZuH/oX+Aw2YzF+xUwLkztIHLozX UIow== X-Received: by 10.66.253.97 with SMTP id zz1mr72776600pac.106.1451759007582; Sat, 02 Jan 2016 10:23:27 -0800 (PST) Received: from psteitz-mbp.local (ip68-106-39-89.ph.ph.cox.net. [68.106.39.89]) by smtp.googlemail.com with ESMTPSA id 79sm110433030pfk.33.2016.01.02.10.23.26 for (version=TLSv1/SSLv3 cipher=OTHER); Sat, 02 Jan 2016 10:23:26 -0800 (PST) Subject: Re: [math] Fixed ant build. To: Commons Developers List References: <811a74fd8d874fd0a1f8289b28c65ae5@git.apache.org> <56881142.4020007@spaceroots.org> From: Phil Steitz X-Enigmail-Draft-Status: N1110 Message-ID: <5688159C.2060002@gmail.com> Date: Sat, 2 Jan 2016 11:23:24 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56881142.4020007@spaceroots.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/2/16 11:04 AM, Luc Maisonobe wrote: > Hi Phil, > > > Le 02/01/2016 18:26, psteitz@apache.org a =E9crit : >> Repository: commons-math >> Updated Branches: >> refs/heads/MATH_3_X c5e6ccb81 -> 68194a3bf >> >> >> Fixed ant build. > Do you want me to run another RC? I was about to say no, and you can see I just voted, but after finding an old 1.5 JDK, I just ran into this: java/org/apache/commons/math3/random/BitsStreamGenerator.java:190: method does not override a method from its superclass [javac] @Override [javac] ^ I think this snuck in after Thomas fixed these 1.5 compilation issues. I am not sure if this is a blocker. It means you can't build the code using a way end of life JDK. But the (slightly fixed) test-jar.xml run under JDK 1.5 runs clean (so people just using the jar with 1.5 should not have a problem). There is one spurious test failure when the tests are run against the release jar under 1.5: Testcase: testCreateFromIntegers(org.apache.commons.math3.distribution.EnumeratedIn= tegerDistributionTest): =20 FAILED expected:<0.5> but was:<0.5000000000000001> junit.framework.AssertionFailedError: expected:<0.5> but was:<0.5000000000000001> The test case uses 0 as the tolerance. Newer JDKs get this exactly, but the 1.5 I have at least fails as above. Phi > > best regards, > Luc > >> >> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo >> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/681= 94a3b >> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/68194a3= b >> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/68194a3= b >> >> Branch: refs/heads/MATH_3_X >> Commit: 68194a3bf5496966ecfdfe1161ae91744782f670 >> Parents: c5e6ccb >> Author: Phil Steitz >> Authored: Sat Jan 2 10:25:49 2016 -0700 >> Committer: Phil Steitz >> Committed: Sat Jan 2 10:25:49 2016 -0700 >> >> ----------------------------------------------------------------------= >> build.xml | 23 +++++++++++++++++------ >> test-jar.xml | 50 ++++++++++++++++---------------------------------- >> 2 files changed, 33 insertions(+), 40 deletions(-) >> ----------------------------------------------------------------------= >> >> >> http://git-wip-us.apache.org/repos/asf/commons-math/blob/68194a3b/buil= d.xml >> ----------------------------------------------------------------------= >> diff --git a/build.xml b/build.xml >> index 89cc433..3e97317 100644 >> --- a/build.xml >> +++ b/build.xml >> @@ -30,12 +30,12 @@ >> =20 >> >> =20 >> + >> =20 >> >> - >> - >> - >> - >> + >> + >> + >> =20 >> >> =20 >> @@ -50,7 +50,7 @@ >> = >> =20 >> >> - >> + >> =20 >> >> >> @@ -111,6 +111,7 @@ >> >> >> >> + >> >> =20 >> >> @@ -121,6 +122,7 @@ >> >> >> >> + >> >> >> =20 >> @@ -343,9 +345,10 @@ >> >> =20 >> > - depends=3D"check-availability" unless=3D"skip.download"> >> + depends=3D"check-availability" unless=3D"skip.download"> >> >> >> + >> >> =20 >> >> @@ -360,6 +363,14 @@ >> usetimestamp=3D"true" ignoreerrors=3D"true" >> src=3D"http://repo1.maven.org/maven2/junit/junit/${junit.= version}/junit-${junit.version}.jar"/> >> >> + >> + >> + >> + >> + > + usetimestamp=3D"true" ignoreerrors=3D"true" >> + src=3D"http://repo1.maven.org/maven2/org/hamcrest/hamcre= st-core/1.3/hamcrest-core-1.3.jar"/> >> + >> =20 >> >> =20 >> >> http://git-wip-us.apache.org/repos/asf/commons-math/blob/68194a3b/test= -jar.xml >> ----------------------------------------------------------------------= >> diff --git a/test-jar.xml b/test-jar.xml >> index c6e12ec..e5a20a5 100644 >> --- a/test-jar.xml >> +++ b/test-jar.xml >> @@ -21,25 +21,23 @@ >> Compiles and runs unit tests against distribution jar(s). Use .an= trc or the=20 >> command line to control the jdk used to execute this build file. = >> =20 >> - Assumes that the distribution jar to be tested is in the base dire= ctory.=20 >> - Use the "jardir" property to specify the path to the directory con= taining >> - the jar. Any other jars in this directory will also be added to th= e >> - classpath. =20 >> + Assumes that the distribution jar to be tested is in the basedir/l= ib, along >> + with any dependent jars (junit, hamcrest). Use the "libdir" proper= ty to specify >> + the path to the directory containing these jars.=20 >> =20 >> The default target, "test," executes clean as a dependency. >> --> >> =20 >> >> - >> - >> + >> >> >> >> - >> - >> + >> + >> + >> >> - >> - >> + >> >> >> >> @@ -58,24 +56,17 @@ >> Java library path: ${java.library.path} >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> >> - >> - >> - >> - >> - >> - >> - >> - >> >> >> >> >> >> - >> + >> >> - >> + > + fork=3D"true" haltonerror=3D"true" showOutput=3D"true"> >> >> - >> + >> >> >> >> @@ -88,14 +79,7 @@ >> >> >> >> - >> - >> - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D WARNING =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> - Junit isn't present in your ${ANT_HOME}/lib directory. Tests not = executed. >> - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >> - >> - >> - >> + >> >> > optimize=3D"false" excludes=3D"**/package.html"> >> @@ -106,12 +90,10 @@ >> >> >> >> - >> - >> - >> - >> + >> + >> >> - >> + >> >> >> =20 >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org