Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D1F5E18761 for ; Mon, 21 Dec 2015 19:46:06 +0000 (UTC) Received: (qmail 31261 invoked by uid 500); 21 Dec 2015 19:46:06 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 31066 invoked by uid 500); 21 Dec 2015 19:46:06 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 31048 invoked by uid 99); 21 Dec 2015 19:46:05 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Dec 2015 19:46:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 31F20C08D9 for ; Mon, 21 Dec 2015 19:46:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.121 X-Spam-Level: X-Spam-Status: No, score=-0.121 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 8Bq2oQaWLOge for ; Mon, 21 Dec 2015 19:46:04 +0000 (UTC) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 710C920273 for ; Mon, 21 Dec 2015 19:46:03 +0000 (UTC) Received: by mail-pa0-f46.google.com with SMTP id cy9so22161619pac.0 for ; Mon, 21 Dec 2015 11:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=e03n5TcMKSm/YS000OBMzy9fV+CSLw/K8UQS+J7UU3g=; b=dyWp/cRt1l9SshUrR/v78lYPteT0u4bV3Znjd6y7Xg/JnBWNb1fdFJUlHb0fdQYeJn lappOPtY5gVdJTAITmKs31vt2gkPMT60VktZdOaNJn3GyQDRt+/elS0GwqlImzg3+atx HdYhPM1PUbmFEB4VrHI+EUJUFzQ1X/qsqdpyWZ3lQ6nGNZ5EAPlqMpgqB2nQU5SzM2Vz Yeea0XTjyDmQNsigX8fiYCKf0gI2K5StC15sw3n9KsvLdkaA+f0fDCjDq6/Jr6ZfHciO lW06iHhlNkxomqazG7oC7fgMbfffVIN94wyoyuRIs7G1na5refGeNBF3Bxx+IXB9SvRl x4lQ== X-Received: by 10.66.218.225 with SMTP id pj1mr29095238pac.40.1450727156498; Mon, 21 Dec 2015 11:45:56 -0800 (PST) Received: from psteitz-mbp.local ([67.133.165.2]) by smtp.googlemail.com with ESMTPSA id e14sm41014639pap.24.2015.12.21.11.45.55 for (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Dec 2015 11:45:55 -0800 (PST) Subject: Re: [math] Updated FieldMatrix exceptions thrown to match javadoc. To: Commons Developers List References: <736fe15c336d418783d2986d94658c59@git.apache.org> <56745F16.7040803@gmail.com> <567481D6.3020504@gmail.com> <56748390.8000100@gmail.com> <567494A8.9020109@gmail.com> <5678072C.6030804@gmail.com> <56785275.3070705@gmail.com> From: Phil Steitz Message-ID: <567856F3.9080401@gmail.com> Date: Mon, 21 Dec 2015 12:45:55 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56785275.3070705@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 12/21/15 12:26 PM, Ole Ersoy wrote: >> Should look like this, with some typos fixed: >> >> /** >> ... >> * @throws MatrixDimensionMismatchException if the dimensions of >> * {@code destination} do not match those of {@code this}. >> * @throws NumberIsTooSmallException if {@code endRow < >> startRow} or >> * {@code endColumn < startColumn}. >> * @throws OutOfRangeException if the indices are not valid. >> */ >> void copySubMatrix(int startRow, int endRow, int startColumn, >> int endColumn, >> T[][] destination) >> throws MatrixDimensionMismatchException, >> NumberIsTooSmallException, >> OutOfRangeException; >> >> I will fix this. > I think it's easier to understand if the "too small" wording is > included. Something like: > > @throws MatrixDimensionMismatchException if the {@code > destination} matrix > dimensions are too small. No, the MatrixDimensionMismatchException is thrown whenever the dimensions don't match exactly, as it says above. Phil > > > Cheers, > Ole > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org