commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@gmx.de>
Subject Re: [VOTE] Release commons-io 2.5 based on RC1
Date Thu, 10 Dec 2015 09:07:24 GMT
Hi Kristian,

Kristian Rosenvold wrote:

> The Charset related tests fail due some character set that is installed in
> your environment that is nor present in mine (commons.io builds fine on
> IBM jdk6 & 7 here). To try to identify which character set we're talking
> about I added the name to the assert message; there is already logic in
> place in these tests to ignore specific character sets.
> 
> If you can run the latest commons-io trunk on your system right now, you
> should get the name of the failing character set and hopefully I can
> install it here and analyze the problem a little more or ignore that
> specific character set.
> 
> The TailerTest was doing two different things which are both problematic;
> it was relying on Thread.sleep(X) sleeping anything remotelly similar to X
> ms, which is known to be untrue. Additionally there is a reliance on gc
> actually running in this interval, which is even more questionable.
> 
> I have "fixed" the sleep part of this issue, leaving the reliance on
> deterministic gc invocation (which I still believe cannot really be done
> reliably without resorting to the debugger api). If this test fails on any
> of your environments I'm partial to just deleting the tests as "not
> possible".
> 
> Let me know about the charset and any other problems you might encounter
> and I'll try to fix them  before spinning RC2 (hopefully this weekend).

I get following problems running trunk with IBM 1.6 (and IBM JDK 1.7):

======================== %< ========================
$ mvn-3.0 -v
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 
14:51:28+0100)
Maven home: /usr/share/maven-bin-3.0
Java version: 1.6.0, vendor: IBM Corporation
Java home: /opt/ibm-jdk-bin-1.6.0.9_p2/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.1.12-gentoo", arch: "amd64", family: "unix"
======================== %< ========================
$ mvn-3.0 -v
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 
14:51:28+0100)
Maven home: /usr/share/maven-bin-3.0
Java version: 1.7.0, vendor: IBM Corporation
Java home: /opt/ibm-jdk-bin-1.7.0.5/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.1.12-gentoo", arch: "amd64", family: "unix"
======================== %< ========================
Running org.apache.commons.io.input.CharSequenceInputStreamTest
Tests run: 30, Failures: 1, Errors: 1, Skipped: 2, Time elapsed: 1.632 sec 
<<< FAILURE! - in org.apache.commons.io.input.CharSequenceInputStreamTest
testAvailable(org.apache.commons.io.input.CharSequenceInputStreamTest)  Time 
elapsed: 1.221 sec  <<< ERROR!
java.lang.UnsupportedOperationException: null
        at java.nio.CharBuffer.arrayOffset(CharBuffer.java:979)
        at 
sun.nio.cs.ext.IBM1388$Encoder.encodeBufferLoop(IBM1388.java:3975)
        at sun.nio.cs.ext.IBM1388$Encoder.encodeLoop(IBM1388.java:4472)
        at java.nio.charset.CharsetEncoder.encode(CharsetEncoder.java:556)
        at 
org.apache.commons.io.input.CharSequenceInputStream.fillBuffer(CharSequenceInputStream.java:123)
        at 
org.apache.commons.io.input.CharSequenceInputStream.read(CharSequenceInputStream.java:169)
        at 
org.apache.commons.io.input.CharSequenceInputStream.skip(CharSequenceInputStream.java:189)
        at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testAvailableSkip(CharSequenceInputStreamTest.java:391)
        at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testAvailable(CharSequenceInputStreamTest.java:430)

testBufferedRead_AvailableCharset(org.apache.commons.io.input.CharSequenceInputStreamTest)
 
Time elapsed: 0.092 sec  <<< FAILURE!
java.lang.AssertionError: bytes should agree expected:<65> but was:<71>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testBufferedRead(CharSequenceInputStreamTest.java:72)
        at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testBufferedRead_AvailableCharset(CharSequenceInputStreamTest.java:96)

Running org.apache.commons.io.input.WindowsLineEndingInputStreamTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec - 
in org.apache.commons.io.input.WindowsLineEndingInputStreamTest
Running org.apache.commons.io.input.BOMInputStreamTest
[Fatal Error] :1:42: Invalid encoding name "UTF-32BE".
[Fatal Error] :1:42: Invalid encoding name "UTF-32LE".
[Fatal Error] :1:42: Invalid encoding name "UTF-32BE".
[Fatal Error] :1:42: Invalid encoding name "UTF-32LE".
[Fatal Error] :1:49: Content is not allowed in prolog.
[Fatal Error] :1:1: Content is not allowed in prolog.
Tests run: 44, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.178 sec 
<<< FAILURE! - in org.apache.commons.io.input.BOMInputStreamTest
testReadXmlWithoutBOMUtf32Be(org.apache.commons.io.input.BOMInputStreamTest)  
Time elapsed: 0.103 sec  <<< ERROR!
org.xml.sax.SAXParseException: Invalid encoding name "UTF-32BE".
        at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        at 
org.apache.commons.io.input.BOMInputStreamTest.parseXml(BOMInputStreamTest.java:158)
        at 
org.apache.commons.io.input.BOMInputStreamTest.testReadXmlWithoutBOMUtf32Be(BOMInputStreamTest.java:664)

testReadXmlWithoutBOMUtf32Le(org.apache.commons.io.input.BOMInputStreamTest)  
Time elapsed: 0.004 sec  <<< ERROR!
org.xml.sax.SAXParseException: Invalid encoding name "UTF-32LE".
        at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        at 
org.apache.commons.io.input.BOMInputStreamTest.parseXml(BOMInputStreamTest.java:158)
        at 
org.apache.commons.io.input.BOMInputStreamTest.testReadXmlWithoutBOMUtf32Le(BOMInputStreamTest.java:672)

testReadXmlWithBOMUtf32Be(org.apache.commons.io.input.BOMInputStreamTest)  
Time elapsed: 0.002 sec  <<< ERROR!
org.xml.sax.SAXParseException: Invalid encoding name "UTF-32BE".
        at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        at 
org.apache.commons.io.input.BOMInputStreamTest.parseXml(BOMInputStreamTest.java:158)
        at 
org.apache.commons.io.input.BOMInputStreamTest.testReadXmlWithBOMUtf32Be(BOMInputStreamTest.java:638)

testReadXmlWithBOMUtf32Le(org.apache.commons.io.input.BOMInputStreamTest)  
Time elapsed: 0.011 sec  <<< ERROR!
org.xml.sax.SAXParseException: Invalid encoding name "UTF-32LE".
        at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        at 
org.apache.commons.io.input.BOMInputStreamTest.parseXml(BOMInputStreamTest.java:158)
        at 
org.apache.commons.io.input.BOMInputStreamTest.testReadXmlWithBOMUtf32Le(BOMInputStreamTest.java:647)

testReadXmlWithBOMUcs2(org.apache.commons.io.input.BOMInputStreamTest)  Time 
elapsed: 0.002 sec  <<< ERROR!
org.xml.sax.SAXParseException: Content is not allowed in prolog.
        at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        at 
org.apache.commons.io.input.BOMInputStreamTest.parseXml(BOMInputStreamTest.java:158)
        at 
org.apache.commons.io.input.BOMInputStreamTest.testReadXmlWithBOMUcs2(BOMInputStreamTest.java:602)

testReadXmlWithBOMUcs4(org.apache.commons.io.input.BOMInputStreamTest)  Time 
elapsed: 0.005 sec  <<< ERROR!
org.xml.sax.SAXParseException: Content is not allowed in prolog.
        at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        at 
org.apache.commons.io.input.BOMInputStreamTest.parseXml(BOMInputStreamTest.java:158)
        at 
org.apache.commons.io.input.BOMInputStreamTest.testReadXmlWithBOMUcs4(BOMInputStreamTest.java:615)

Running org.apache.commons.io.output.WriterOutputStreamTest
Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.043 sec 
<<< FAILURE! - in org.apache.commons.io.output.WriterOutputStreamTest
testUTF16WithSingleByteWrite(org.apache.commons.io.output.WriterOutputStreamTest)  
Time elapsed: 0.006 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[à peine arrivés nous entrâmes dans 
sa chambre]> but was:<[＀ 瀀攀椀渀攀 愀爀爀 椀瘀猀 渀漀甀猀 攀渀琀爀洀攀猀 搀愀渀猀 猀愀 挀栀愀洀戀爀]>
        at org.junit.Assert.assertEquals(Assert.java:115)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at 
org.apache.commons.io.output.WriterOutputStreamTest.testWithSingleByteWrite(WriterOutputStreamTest.java:49)
        at 
org.apache.commons.io.output.WriterOutputStreamTest.testUTF16WithSingleByteWrite(WriterOutputStreamTest.java:88)

======================== %< ========================

Test output is with IBM JDK 1.6, the output with 1.7 is the same apart from 
the line numbers in the stacktrace.

Cheers,
Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message