commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thammegowda <...@git.apache.org>
Subject [GitHub] commons-io pull request: Added a true iterator based
Date Wed, 16 Dec 2015 08:51:03 GMT
GitHub user thammegowda opened a pull request:

    https://github.com/apache/commons-io/pull/9

    Added a true iterator based

    ## What is the issue with existing iterator ?
    1. The existing `iterateFiles()`  is not really an iterator. It uses an in memory list
which is problematic when dealing with millions of child files.
    2. The existing one blocks till  it traverses the whole tree to build the list. 
    
    -- 
    ## What is good about the new iterator?
    1. This one performs depth first traversal on file tree with the help of a stack as and
when the files are consumed,. So no in memory list.
    2. It doesnt block till it read all the file descriptors. You are good to consume the
moment the first file is read
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thammegowda/commons-io trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit 6719879b257d04b39e9acdb3cb89f8bba9b3ecf0
Author: Thamme Gowda N <tgowdan@gmail.com>
Date:   2015-12-16T08:38:43Z

    Added a true iterator based
    
    The existing one uses a in memory list which is problematic
     when dealing with millions of child files.
    This one performs depth first traversal on file tree
     with the help of a stack.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message