commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Rosenvold <kristian.rosenv...@gmail.com>
Subject Re: [VOTE] Release commons-io 2.5 based on RC1
Date Wed, 09 Dec 2015 20:06:50 GMT
The Charset related tests fail due some character set that is installed in
your environment that is nor present in mine (commons.io builds fine on IBM
jdk6 & 7 here). To try to identify which character set we're talking about
I added the name to the assert message; there is already logic in place in
these tests to ignore specific character sets.

If you can run the latest commons-io trunk on your system right now, you
should get the name of the failing character set and hopefully I can
install it here and analyze the problem a little more or ignore that
specific character set.

The TailerTest was doing two different things which are both problematic;
it was relying on Thread.sleep(X) sleeping anything remotelly similar to X
ms, which is known to be untrue. Additionally there is a reliance on gc
actually running in this interval, which is even more questionable.

I have "fixed" the sleep part of this issue, leaving the reliance on
deterministic gc invocation (which I still believe cannot really be done
reliably without resorting to the debugger api). If this test fails on any
of your environments I'm partial to just deleting the tests as "not
possible".

Let me know about the charset and any other problems you might encounter
and I'll try to fix them  before spinning RC2 (hopefully this weekend).

Kristian


2015-11-26 14:20 GMT+01:00 Jörg Schaible <joerg.schaible@gmx.de>:

> Kristian Rosenvold wrote:
>
> >   We have fixed quite a few bugs and added some significant
> > enhancements since commons-io was released,
> >   so I would like to release commons-io 2.5
> >
> >   Foo 2.5 RC1 is available for review here:
> >     https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision
> >     11266)
> >
> >   Maven artifacts are here:
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1123
> >
> >   Details of changes since 2.4 are in the release notes:
> >     https://dist.apache.org/repos/dist/dev/commons/io/RELEASE-NOTES.txt
> >
> http://people.apache.org/~krosenvold/commons-io-2.5-RC1/changes-report.html
> >
> >   I have tested this with JDK 1.6, 1.7 and 1.8.
> >
> >   The tag is here:
> >
> https://svn.apache.org/repos/asf/commons/proper/io/tags/commons-io-2.5-RC1
> > (r1715890)
> >
> >   Site:
> >      http://people.apache.org/~krosenvold/commons-io-2.5-RC1/
> >   (note some *relative* links are broken and the 2.5 directories are
> >   not yet created - these will be OK once the site is deployed)
> >
> >   Clirr Report (compared to 2.4):
> >
> http://people.apache.org/~krosenvold/commons-io-2.5-RC1/clirr-report.html
> >
> >
> >   RAT Report:
> >
> http://people.apache.org/~krosenvold/commons-io-2.5-RC1/rat-report.html
> >
> >   KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> >   Please review the release candidate and vote.
> >   This vote will close no sooner that 72 hours from now, i.e. after
> > 19:00 CET 26-March 2015
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
>
>
> IBM JDK 1.6 fails (as usual):
> =========================== %< =======================
> Failed tests:
>   CharSequenceInputStreamTest.testBufferedRead_AvailableCharset:96-
> >testBufferedRead:72 bytes should agree expected:<65> but was:<71>
>   WriterOutputStreamTest.testUTF16WithSingleByteWrite:81-
> >testWithSingleByteWrite:47 expected:<[à peine arrivés nous entrâmes dans
> sa
> chambre]> but was:<[＀ 瀀攀椀渀攀 愀爀爀椀瘀猀 渀漀甀猀 攀渀琀爀洀攀猀
搀愀渀猀 猀愀 挀栀愀洀戀爀]>
> Tests in error:
>   BOMInputStreamTest.testReadXmlWithBOMUcs2:602->parseXml:158 » SAXParse
> Content...
>   BOMInputStreamTest.testReadXmlWithBOMUcs4:615->parseXml:158 » SAXParse
> Content...
>   BOMInputStreamTest.testReadXmlWithBOMUtf32Be:638->parseXml:158 » SAXParse
> Inva...
>   BOMInputStreamTest.testReadXmlWithBOMUtf32Le:647->parseXml:158 » SAXParse
> Inva...
>   BOMInputStreamTest.testReadXmlWithoutBOMUtf32Be:664->parseXml:158 »
> SAXParse I...
>   BOMInputStreamTest.testReadXmlWithoutBOMUtf32Le:672->parseXml:158 »
> SAXParse I...
>   CharSequenceInputStreamTest.testAvailable:430->testAvailableSkip:391 »
> UnsupportedOperation
>
> Tests run: 1156, Failures: 2, Errors: 7, Skipped: 2
> =========================== %< =======================
>
> IBM JDK 1.7 fails also:
> =========================== %< =======================
> Failed tests:
>   CharSequenceInputStreamTest.testBufferedRead_AvailableCharset:96-
> >testBufferedRead:72 bytes should agree expected:<111> but was:<-3>
>   WriterOutputStreamTest.testUTF16WithSingleByteWrite:81-
> >testWithSingleByteWrite:47 expected:<[à peine arrivés nous entrâmes dans
> sa
> chambre]> but was:<[＀ 瀀攀椀渀攀 愀爀爀椀瘀猀 渀漀甀猀 攀渀琀爀洀攀猀
搀愀渀猀 猀愀 挀栀愀洀戀爀]>
> Tests in error:
>   BOMInputStreamTest.testReadXmlWithBOMUcs2:602->parseXml:158 » SAXParse
> Content...
>   BOMInputStreamTest.testReadXmlWithBOMUcs4:615->parseXml:158 » SAXParse
> Content...
>   BOMInputStreamTest.testReadXmlWithBOMUtf32Be:638->parseXml:158 » SAXParse
> Inva...
>   BOMInputStreamTest.testReadXmlWithBOMUtf32Le:647->parseXml:158 » SAXParse
> Inva...
>   BOMInputStreamTest.testReadXmlWithoutBOMUtf32Be:664->parseXml:158 »
> SAXParse I...
>   BOMInputStreamTest.testReadXmlWithoutBOMUtf32Le:672->parseXml:158 »
> SAXParse I...
>   CharSequenceInputStreamTest.testAvailable:430->testAvailableSkip:391 »
> UnsupportedOperation
> =========================== %< =======================
>
>
> This test seems brittle, it failed for me one time using IcedTea 7
> (OpenJDK), but passed a 2nd run:
> =========================== %< =======================
> Failed tests:
>   TailerTest.testTailer:225 2 line count expected:<1> but was:<3>
>
> Tests run: 1156, Failures: 1, Errors: 0, Skipped: 3
> =========================== %< =======================
>
> +1, since it's no regression that the IBM JDK's always fail these tests.
>
> Cheers,
> Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message