commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1
Date Tue, 22 Dec 2015 23:07:14 GMT
On 12/22/15 12:56 PM, Matt Benson wrote:
> On Dec 22, 2015 1:27 PM, "Phil Steitz" <phil.steitz@gmail.com> wrote:
>> On 12/22/15 12:05 AM, Matt Benson wrote:
>>> On Dec 21, 2015 8:46 PM, "James Carman" <james@carmanconsulting.com>
> wrote:
>>>> Can you just abandon the ant build?
>>>>
>>> It's not an Ant build; it's an Antlib to allow Ant users to use the
> weaver
>>> component in a manner similar to how Maven users would do at build
> time. I
>>> came into the ASF via Ant; the least I can do is be inclusive.
>> +1
>> But couldn't you just add get-deps or something similar to grab the
>> dependencies? Or is the shading in part to avoid version conflicts?
>> That should not be a problem for the shaded commons components in
>> there.  Is it for asm?
> It is definitely an issue for asm. They have never changed package names
> even when they switched from an interface based design to an abstract class
> based design. Their site explicitly recommends repackaging.

Ugh.  Then I guess there is no practical choice so best it to just
include their required notice in NOTICE and ship it shaded.

Phil
>
> Matt
>> Phil
>>> Matt
>>>
>>>> On Fri, Dec 18, 2015 at 6:41 PM Matt Benson <gudnabrsam@gmail.com>
> wrote:
>>>>> On Fri, Dec 18, 2015 at 5:31 PM, Phil Steitz <phil.steitz@gmail.com>
>>> wrote:
>>>>>> On 12/18/15 3:38 PM, Matt Benson wrote:
>>>>>>> On Fri, Dec 18, 2015 at 4:33 PM, Phil Steitz <phil.steitz@gmail.com>
>>> wrote:
>>>>>>>> On 12/17/15 3:57 PM, Matt Benson wrote:
>>>>>>>>> I would like to release the [weaver] component.
>>>>>>>>>
>>>>>>>>> Apache Commons Weaver 1.2 RC1 is available for review
at:
>>>>>>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/
(r11649).
>>>>>>>>>
>>>>>>>>> Maven artifacts are at:
>>>>>>>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-1132
> .
>>>>>>>>> Tested with Oracle JDKs 7 and 8; IBM JDK 7.
>>>>>>>>>
>>>>>>>>> The Subversion tag is:
>>>>>>>>>
>>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC1/
>>>>>>>>> (r1720616).
>>>>>>>>>
>>>>>>>>> Site (note some links may be broken; this will be fixed
when the
>>> site
>>>>>>>>> is deployed):
>>>>>>>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/index.html
>>>>>>>>> RAT Report:
>>>>>>>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/rat-report.html
>>>>>>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>>>>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/commons-weaver-parent/commons-weaver-processor/project-reports.html
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc1/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>>>>>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>>>>>>>>
>>>>>>>>> Please review the release candidate and vote.
>>>>>>>>>   This vote will close no sooner than 72 hours from now,
i.e.
> after
>>>>>>>>> 2300UTC 20-December 2015
>>>>>>>>>
>>>>>>>>>   [ ] +1 Release these artifacts
>>>>>>>>>   [ ] +0 OK, but...
>>>>>>>>>   [ ] -0 OK, but really should fix...
>>>>>>>>>   [ x ] -1 I oppose this release because...
>>>>>>>> Something has to be added to NOTICE or LICENSE to comply
with
>>>>>>>> http://asm.ow2.org/license.html
>>>>>>>>
>>>>>>>> since some ow2 classes are shipped in (at least) the normalizer
> jar.
>>>>>>> Okay, this seems like a good enough reason to fail RC1 and I
can
>>>>>>> pummel the Java 6 build into submission at the same time. Any
idea
>>>>>>> what form this attribution should take? Should it all be somehow
>>>>>>> stuffed into the NOTICE file?
>>>>>> I have lost track of the debates around LICENSE vs NOTICE for this
>>>>>> stuff.  I would shove it into NOTICE myself, but I am not sure that
>>>>>> is correct.  Anyone else know?
>>>>>>
>>>>>> Of course, ditching the shading would make the problem go away ;)
>>>>>>
>>>>> The idea is that if you're an Ant user you don't want to go hunting
>>>>> around for 19 artifacts for your build, so the jars are built to "just
>>>>> work." All you need is the Antlib and whatever weaver module(s) you
>>>>> may need and you're ready to go.
>>>>>
>>>>> So far, I have:
>>>>>
>>>>> * corrected the build to work with Java 6
>>>>> * customized the NOTICE files for the weaver modules and the Antlib
>>>>>
>>>>> Can anybody find anything else wrong with RC1 before I cut RC2?
>>>>>
>>>>> Thanks,
>>>>> Matt
>>>>>
>>>>>> Phil
>>>>>>> Thanks,
>>>>>>> Matt
>>>>>>>
>>>>>>>> Phil
>>>>>>>>
>>>>>>>>>   Thanks!
>>>>>>>>>
>>>>>>>>>
>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>>
> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message