commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.
Date Mon, 21 Dec 2015 19:45:55 GMT
On 12/21/15 12:26 PM, Ole Ersoy wrote:
>> Should look like this, with some typos fixed:
>>
>> /**
>>      ...
>>      * @throws MatrixDimensionMismatchException if the dimensions of
>>      * {@code destination} do not match those of {@code this}.
>>      * @throws NumberIsTooSmallException if {@code endRow <
>> startRow} or
>>      * {@code endColumn < startColumn}.
>>      * @throws OutOfRangeException if the indices are not valid.
>>      */
>>      void copySubMatrix(int startRow, int endRow, int startColumn,
>> int endColumn,
>>                         T[][] destination)
>>      throws MatrixDimensionMismatchException,
>> NumberIsTooSmallException,
>>      OutOfRangeException;
>>
>> I will fix this.
> I think it's easier to understand if the "too small" wording is
> included.  Something like:
>
> @throws MatrixDimensionMismatchException if the {@code
> destination} matrix
>  dimensions are too small.

No, the MatrixDimensionMismatchException is thrown whenever the
dimensions don't match exactly, as it says above.

Phil
>
>
> Cheers,
> Ole
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message