commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] commons-compress pull request: Pkware headers
Date Sun, 13 Dec 2015 16:42:21 GMT
Github user bodewig commented on the pull request:

    https://github.com/apache/commons-compress/pull/5#issuecomment-164276454
  
    Thanks
    
    I've merged you patch have a few questions - and would like to see tests :-)  Not sure
whether you'd prefer to discuss this here, inside a new PR or on the dev list.
    
    I'm note sure why you've introduced the base class `PKWareExtraHeader`. It might be useful
as a container but I don't see why the others inherit from it.
    
    Second, don't you want to register the new classes `ExtraFieldUtils`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message