commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From luc <...@spaceroots.org>
Subject Re: [5/6] [math] Fixed findbugs warning.
Date Wed, 04 Nov 2015 13:54:43 GMT
Le 2015-11-04 14:34, Gilles a écrit :
> On Wed, 04 Nov 2015 14:20:55 +0100, Gilles wrote:
>>>> [...]
>>>> But it was perhaps a bad design choice to have "PairNeuronDouble" 
>>>> implement
>>>> "Comparable".
>>>> I propose to use an explicit "Comparator" in order to fix the 
>>>> problem.
>>> 
>>> Good idea!
>>> I have done it and pushed it on both master and MATH_3_X branches.
>> 
>> I was working on that! :-(
> 
> And I've just overwritten (sorry!) your changes in "master" with
> something that would seem to be a little bit more efficient.
> 
> I've _not_ done so in the MATH_3_X branch.
> Will you do the "back-porting"?

Fine, I've done it.
I have also removed the geValue method since it was not needed anymore.

best regards,
Luc

> 
> Gilles
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message