commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles <gil...@harfang.homelinux.org>
Subject Re: [Math] Compile only top-level package and below
Date Sat, 05 Sep 2015 00:13:34 GMT
On Sat, 5 Sep 2015 00:56:54 +0100, sebb wrote:
> On 5 September 2015 at 00:55, Ole Ersoy <ole.ersoy@gmail.com> wrote:
>>
>>
>> On 09/04/2015 06:06 PM, Gilles wrote:
>>>
>>> On Fri, 4 Sep 2015 11:03:08 -0500, Ole Ersoy wrote:
>>>>
>>>> On 09/04/2015 10:26 AM, Gilles wrote:
>>>>>
>>>>> On Fri, 4 Sep 2015 10:11:04 -0500, Ole Ersoy wrote:
>>>>>>
>>>>>> You have left over files in `target` after switching between the
>>>>>> branches.  For example check out `math4`.  Build it.  Switch to 
>>>>>> the
>>>>>> `math3` branch.  Build it.  Now `target` will contain both 
>>>>>> classes
>>>>>> from the math3 branch and the math4 branch.
>>>>>
>>>>>
>>>>> No it's not the problem.
>>>>> They are _source_ files.
>>>>
>>>> Ahh - OK - Not sure if this will help, but you can for example
>>>> exclude the math3 package files from compilation like this:
>>>>
>>>>
>>>>
>>>> 
>>>> |<plugin><groupId>org.apache.maven.plugins</groupId><artifactId>maven-compiler-plugin</artifactId><version>2.0.2</version><configuration><source>1.6</source><target>1.6</target><includes><include>org/apace/commons/math4/*.java</include>
>>>> </includes> </configuration> </plugin> </plugins>|
>>>>
>>>
>>> That works fine!
>>>
>>> Thus it's not that maven _has_ to compile everything under 
>>> "src/main";
>>> it can be told otherwise.
>>> Perhaps there are nasty side effects to that selection (?).
>>
>> If someone clones the master off of github in order to experiment 
>> and they
>> are used to being able to compile everything under `src/main/java` 
>> then they
>> may be in for a surprise.
>>
>>>
>>> Otherwise, I still don't understand why it cannot be included in 
>>> the
>>> POM file...
>>
>>
>> You could create two new branches that you have your own POM 
>> modifications
>> in:
>>
>> - math3-gilles
>> - math4-gilles

IIUC, that would exchange "stash" for "merge".
I fail to see the gain. :-{

>
> +1 to that!
>
> -1 to adding the changes to the main branches.

Hmm, the POM contains several CM-tailored instructions (include this,
exclude that), plus (IIRC) we don't ship source files that are not
below "o.a.c.math3".  Thus why not reflect that in the POM too?
[It's the reverse of an argument given by Luc: why keep source files
under the project's "src/main/java/org/apache/commons/math3" if it's
*not* going to be part of the official project?]

Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message