commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1697267 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: classfile/ generic/ verifier/structurals/
Date Mon, 24 Aug 2015 10:07:41 GMT
On 24 August 2015 at 10:57, Jörg Schaible <joerg.schaible@swisspost.com> wrote:
> Hi Sebb,
>
> sebb wrote:
>
>> On 24 August 2015 at 08:04, Jörg Schaible <joerg.schaible@swisspost.com>
>> wrote:
>>> Hi Sebb,
>>>
>>> sebb wrote:
>>>
>>>> On 23 August 2015 at 23:19,  <dbrosius@apache.org> wrote:
>>>>> Author: dbrosius
>>>>> Date: Sun Aug 23 22:19:04 2015
>>>>> New Revision: 1697267
>>>>>
>>>>> URL: http://svn.apache.org/r1697267
>>>>> Log:
>>>>> remove the need for casting at the clone() call site
>>>>
>>>> -1
>>>>
>>>> I was hoping to reduce the number of API changes to the minimum, so we
>>>> can potentially release a
>>>> version that is binary compatible with 5.2.
>>>
>>> Are you sure that this is binary incompatible? IIRC it is safe to adjust
>>> the return type of clone here.
>>
>> It's not binary compatible because the return type is part of the
>> method signature.
>>
>> I think it may well be source compatible.
>
> No, because the exception is no longer thrown (error depends on the compiler
> settings)

Huh? The commit did not change the throws clauses (there were none)

> or if someone has overloaded the method with return type Object.

Here I agree.

> Cheers,
> Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message