commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release BCEL 6.0 based on RC4
Date Mon, 10 Aug 2015 17:06:59 GMT
On Mon, Aug 10, 2015 at 5:35 AM, sebb <sebbaz@gmail.com> wrote:

> On 10 August 2015 at 13:17, Dave Brosius <dbrosius@apache.org> wrote:
> > I'm not sure having the 6 in bcel6 is such a good idea. the prefix
> already
> > disambiguates the package name, so this isn't needed and is kind of
> > limiting.
>
> The convention has been to tie the package/component names to the
> major release version.
>
> However, I agree it's not necessary for the first API break, given
> that we are changing to commons prefixes.
>
> We could drop the 6 now, and only add the major version suffix if a
> further API-breaking major release is needed.
>

I asked for a Clirr report vs 5.2, so we'll see what that yields. The
package name will have to be temporarily (or locally) changed back for that
report to be built.

Gary

>
> >
> > On 08/10/2015 06:49 AM, sebb wrote:
> >>
> >> Assuming that the package name change is required, then there are also
> >> a lot of mutable non-private fields that need to be made private.
> >>
> >> I am happy to make these changes, but I don't wish to change the API
> >> until the need for a break is established.
> >>
> >> On 10 August 2015 at 11:22, sebb <sebbaz@gmail.com> wrote:
> >>>
> >>> I am currently -1 because of:
> >>>
> >>> Several uses of deprecated methods and classes.
> >>> Given that there is a new package name/Maven id, now is the time to
> >>> remove any deprecated items.
> >>>
> >>> There is some very strange code in Utility.java:
> >>> 865 & 868:                        consumed_chars = ++consumed_chars;
> >>>
> >>> There may be some other issues; I need to have a further look.
> >>>
> >>> On 10 August 2015 at 04:55,  <chas@honton.org> wrote:
> >>>>
> >>>>   The last BCEL release (5.2) occurred in February of 2006.  It’s
been
> >>>> nine
> >>>> years since the last release and four years since the code was
> >>>> transferred
> >>>> to commons.  Over this time, java byte code has been enhanced with
> >>>> additional opcodes and dynamic language support.  Supporting these
> byte
> >>>> code
> >>>> changes is the most significant feature of BCEL-6.0.
> >>>>
> >>>>    BCEL 6.0 RC4 is available for review here:
> >>>>      https://dist.apache.org/repos/dist/dev/commons/bcel (svn
> revision
> >>>> 10111)
> >>>>
> >>>>    Maven artifacts are here:
> >>>>
> >>>>
> >>>>
> https://repository.apache.org/content/repositories/orgapachecommons-1104/org/apache/commons/commons-bcel6/6.0/
> >>>>
> >>>>    Details of changes since 5.2 are in the release notes:
> >>>>
> >>>> https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
> >>>>      https://people.apache.org/~chas/bcel-6.0-RC4/changes-report.html
> >>>>
> >>>>    I have tested this with JDK 1.7 using maven3.
> >>>>
> >>>>    The tag is here:
> >>>>
> >>>>
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC4/
> >>>> (svn revision 1694950)
> >>>>
> >>>>    Site:
> >>>>      https://people.apache.org/~chas/bcel-6.0-RC4/
> >>>>    (note some *relative* links are broken - these should be OK once
> the
> >>>> site
> >>>> is deployed)
> >>>>
> >>>>    Clirr Report:
> >>>>      N/A
> >>>>
> >>>>    RAT Report:
> >>>>      https://people.apache.org/~chas/bcel-6.0-RC4/rat-report.html
> >>>>
> >>>>    KEYS:
> >>>>    https://www.apache.org/dist/commons/KEYS
> >>>>
> >>>>    Please review the release candidate and vote.
> >>>>    This vote will close no sooner that 72 hours from now, i.e. after
> >>>> 1800 GMT
> >>>> 12 August 2015
> >>>>
> >>>>    [ ] +1 Release these artifacts
> >>>>    [ ] +0 OK, but...
> >>>>    [ ] -0 OK, but really should fix...
> >>>>    [ ] -1 I oppose this release because...
> >>>>
> >>>> Thanks!
> >>>> Chas
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message