commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts" <mar...@cs.washington.edu>
Subject BCEL design goals? (was RE: [jira] [Commented] (BCEL-233) The access_flags field in AccessFlags class should be final)
Date Fri, 14 Aug 2015 22:55:07 GMT
I hope this doesn't come across as too strident, but working towards a resolution of this particular
issue has got me thinking about how I use BCEL - and this seems like a good time/place to
clarify my understanding of BCEL's purpose.  

Simply stated, it is my belief that a client should be able to read and/or write any member,
field, flag, or what have you in a .class file.

Is that assuming too much?  Are there any intentional restrictions?

Thanks,
Mark


-----Original Message-----
From: Sebb (JIRA) [mailto:jira@apache.org] 
Sent: Friday, August 14, 2015 3:30 PM
To: markro@cs.washington.edu
Subject: [jira] [Commented] (BCEL-233) The access_flags field in AccessFlags class should
be final


    [ https://issues.apache.org/jira/browse/BCEL-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697872#comment-14697872
] 

Sebb commented on BCEL-233:
---------------------------

OK, have you got any sample code that could be used as test cases?

> The access_flags field in AccessFlags class should be final
> -----------------------------------------------------------
>
>                 Key: BCEL-233
>                 URL: https://issues.apache.org/jira/browse/BCEL-233
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 6.0
>
>
> The access_flags field in the AccessFlags class should be final.
> It is currently not set by any other classes outside their constructors.
> The public setters - e.g. isPrivate(boolean) - are not used and should be deleted. [Apart
from that, their names are really confusing.]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message